In a server-side ruby plugin, I’m using DiscourseEvent.on("post_created") to get data on post replies. However, this is also being triggered when a person replies to a private message. Unfortunately, I can’t see any attributes on the event objects that allow me to distinguish a reply to a topic from a reply in a PM conversation. The archetype property is set to “regular” in both of these cases. Does anyone have any ideas how to distinguish a private message reply from other messages?

Something might be wrong, because the topic.archetype == "private_message" is the way to differentiate regular posts from PMs.

Yea, I’m seeing the initial PM come through with that archetype, but replies after the initial message are “regular”.

But the archetype is on the topic, not on the post. I just tried a new PM on my dev instance and the archetype is private_message.

[תמונה] Falco: I just tried a new PM on my dev instance and the archetype is private_message. Yea, but what about subsequent messages in the PM conversation? Those have regular. edit: I’m testing on 1.7.0.beta5

[תמונה] tim.smith: Yea, but what about subsequent messages in the PM conversation? Those have regular. But isn’t the archetype on the topic instead of the post? In the database there is only one line per topic, and it’s set correctly. Where are you testing this info?

Here’s the code that I’m using to trace out the event objects: Discourse-Webhooks/plugin.rb at master · purecloudlabs/Discourse-Webhooks · GitHub Here’s the result of that trace for a PM reply. I believe the topic is the second object in the params array. I’ve truncated the user object for brevity. [ { "id": 242, "user_id": 2, "topic_id": 177, "post_number": 3, "raw": "replying in a PM asdf1234", "cooked": " replying in a PM asdf1234 ", "created_at": "2016-10-12T21:03:33.334Z", "updated_at": "2016-10-12T21:03:33.334Z", "reply_to_post_number": null, "reply_count": 0, "quote_count": 0, "deleted_at": null, "off_topic_count": 0, "like_count": 0, "incoming_link_count": 0, "bookmark_count": 0, "avg_time": null, "score": null, "reads": 0, "post_type": 1, "vote_count": 0, "sort_order": 3, "last_editor_id": 2, "hidden": false, "hidden_reason_id": null, "notify_moderators_count": 0, "spam_count": 0, "illegal_count": 0, "inappropriate_count": 0, "last_version_at": "2016-10-12T21:03:33.350Z", "user_deleted": false, "reply_to_user_id": null, "percent_rank": 1, "notify_user_count": 0, "like_score": 0, "deleted_by_id": null, "edit_reason": null, "word_count": 5, "version": 1, "cook_method": 1, "wiki": false, "baked_at": "2016-10-12T21:03:33.334Z", "baked_version": 1, "hidden_at": null, "self_edits": 0, "reply_quoted": false, "via_email": false, "raw_email": null, "public_version": 1, "action_code": null }, { "raw": "replying in a PM asdf1234", "topic_id": "177", "archetype": "regular", "category": "", "typing_duration_msecs": "1900", "composer_open_duration_msecs": "11839", "visible": true, "is_warning": false, "ip_address": "127.0.0.1", "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36", "referrer": "https://developer.inindca.com/forum/t/hey-this-is-a-pm/177", "first_post_checks": true }, { "id": 2, "username": "tim.smith", "avatar_template": "/forum/user_avatar/developer.inindca.com/tim.smith/{size}/58_1.png", "name": "Tim Smith", "last_posted_at": "2016-10-12T21:03:33.334Z", "last_seen_at": "2016-10-12T21:03:14.864Z" } ] edit: here’s a screenshot showing that the post is indeed a reply to a PM: [תמונה]

Hmmm I think this params variable isn’t used elsewhere. And on brand new official WebHooks for post created we only send down the topic id.

[תמונה] Falco: Hmmm I think this params variable isn’t used elsewhere. The params variable is the name of the variable in my plugin, not something in Discourse. It’s an array of the 3 parameters passed into a Discourse event, presumably via DiscourseEvent.trigger(...). Here’s where it’s defined in my plugin: Discourse-Webhooks/plugin.rb at master · purecloudlabs/Discourse-Webhooks · GitHub [תמונה] Falco: And on brand new official WebHooks for post created we only send down the topic id. I’m not using Discourse’s webhooks. I’m consuming events in my plugin that are raised by Discourse directly, parsing/formatting the event data, and sending my own webhook.

[תמונה] tim.smith: . I’m consuming events in my plugin that are raised by Discourse directly, parsing/formatting the event data, and sending my own webhook. In that case, you need to add post.topic.archetype as a field that gets sent. Or, do Guardian.new(plugin _user).can_see? post and use the standard visibility checks.

you need to add post.topic.archetype as a field that gets sent. What do you mean? The field is there in the event data for PM replies. It’s just set to “regular” so I can’t distinguish it from a reply to a topic. Or, do Guardian.new(plugin _user).can_see? post and use the standard visibility checks. Can you point me to some documentation on what Guardian is and why I need a new one? Also documentation for how to do a visibility check and which ones are standard?

Distinguish private messages from posts?

Development

Mittineague (Mittineague) 13 באוקטובר,‏ 2016,‏ 3:44pm 12

Are you confusing Topic archetype with Post post_type?

Guardian files can be seen here

נושא		תגובות	צפיות
Webhooks: how best to differentiate a PM from a public post Development webhooks	12	1572	24 בספטמבר,‏ 2019
PM replies have wrong archetype Bug pr-welcome	1	983	22 בנובמבר,‏ 2016
Discourse webhook displays private messages Product Support	3	1423	26 ביוני,‏ 2018
Discourse Private Replies Plugin	60	9613	20 באפריל,‏ 2026
Making a difference between public topic and private message on API Feature	3	634	1 בפברואר,‏ 2019

Distinguish private messages from posts?

נושאים קשורים