I’m updating bbpress.rb to have it deal with attachments (now it inserts a link to the attachment on the original site) and create permalinks for the old URLs. The old format is `/forums/topic/slug’. For anyone who knows how to write an Nginx redirect, it’s pretty simple to redirect that to /t/slug and be done with it. OTOH at this particular instant, it is faster for me to add code to the importer to create those permalinks. Question: Is there any reason not to create a permalink for every topic?

There is an option already. [image] Redirect old forum URLs to new Discourse URLs using permalinks packageMigrating to Discourse bookmark This reference explains how Discourse permalinks redirect old URL paths to new destinations, how permalink normalizations work, and how to test and troubleshoot redirects after a migration or URL structure change. person_raising_hand Required user level: Administrator computer Console access required only when creating permalinks from an importer, script, or Rails console When you migrate from another forum or change your site’s URL structure, old links from search engines,… Are you looking for something else?

[image] vinothkannans: Are you looking for something else? No, that’s what I’m doing, though rather than having to enter the rails console and find a way to do a Permalink.create for every URL, I’m doing that automatically in the importer. Normal People should not be subjected to the Rails console. :slight_smile: My current hypothesis is that it might actually be (a very tiny bit) better to have Discourse do the redirects than to get Nginx to do it, as adding that redirect will cause Nginx to have to process it on every url request.

[image] pfaffman: better to have Discourse do the redirects than to get Nginx to do it, as adding that redirect will cause Nginx to have to process it on every url request. Actually, doing it on Nginx should be way faster than doing in Discourse. The problem is that Discourse is way easier, friendly and portable, while Nginx should be treated in a case-by-case basis.

Thanks, @falco. I’ll take that as a “no.” There’s no reason not to have the importer add a redirect for every topic, and no reason to make it easy to turn off that functionality (e.g., by setting an environment variable).

in phpbb3 importer script they already using it script/import_scripts/phpbb3/importers/permalink_importer.rb main add_normalization(normalizations, TOPIC_LINK_NORMALIZATION) if @settings.create_topic_links SiteSetting.permalink_normalizations = normalizations.join("|") end def create_for_category(category, import_id) return unless @settings.create_category_links && category url = "viewforum.php?f=#{import_id}" Permalink.create(url: url, category_id: category.id) unless permalink_exists(url) end def create_for_topic(topic, import_id) return unless @settings.create_topic_links && topic url = "viewtopic.php?t=#{import_id}" Permalink.create(url: url, topic_id: topic.id) unless permalink_exists(url) end Hope it can help you :slight_smile:

Maybe having an easy turn off is a good thing. If I were doing a special custom import, I would prefer the nginx redirect route. But having the code in a reusable script that doesn’t make me do it every time is very valuable.

[image] Falco: One to turn it all off (default on) looks good for me. Done. But, if it’s you that we’re talking about, you can just put a # in the front of the create_permalinks call in execute. :slight_smile:

One to turn it all off (default on) looks good for me.

https://github.com/discourse/discourse/pull/4501

[image] pfaffman: Is there any reason not to create a permalink for every topic Nope, I can not think of any performance reasons to avoid permalink creation, it does an indexed lookup which is very cheap.

Permalink overhead

Development

sam (Sam Saffron) October 17, 2016, 1:13am 11

Nope, I can not think of any performance reasons to avoid permalink creation, it does an indexed lookup which is very cheap.

Topic		Replies	Views
Non-permalink normalizations Development	11	1516	May 11, 2017
Redirect old forum URLs to new Discourse URLs using permalinks Migrating to Discourse how-to	10	30307	September 13, 2024
Custom permalinks Product Support	5	6175	March 7, 2020
Redirecting the old forum urls to the discourse Product Support unsupported-install	18	1599	September 11, 2020
Redirecting Problems Product Support	10	1227	May 11, 2019

Permalink overhead

Related topics