Since the latest upgrade, my plugin button in the admin dashboard menu has lost the correct styling, as you can see here: [image] My /connectors/admin-menu/app-admin-connector.hbs template looks like this: {{#link-to 'admin.pvda'}}{{i18n 'pvda.admin.menu_title'}}{{/link-to}}

I see that in the file app/assets/javascripts/admin/templates/admin.hbs the line: {{plugin-outlet "admin-menu" tagName="li"}} has been changed to: {{plugin-outlet name="admin-menu" connectorTagName="li"}}

For those interested, this is my workaround until someone from the Discourse team fixes it. Basically I need to unwrap the stuff inside the span like this: ... ` to this: ... {{#link-to 'admin.pvda' id='admin-menu-pvda'}} {{i18n 'pvda.admin.menu_title'}} {{/link-to}} api.onPageChange((url, title) => { // --- ADMIN PAGE --- // if (/\/admin\//.test(url)) { // Admin pages start with "/admin/*" let sel = '#admin-menu-pvda', pvda_menu_item = $(sel); if (pvda_menu_item.length) { let li = pvda_menu_item.parent(); if (li.is("li")) { let span = li.parent(); if (span.is("span")) { li.unwrap(); } } } } ... }

I think this is related to something @sam uncovered recently too [image] Important changes to Plugin Outlets for Ember 2.10 Development Just to expand a bit, looks like if you want to set a class on wrapping component you would use: api.registerConnectorClass('user-profile-primary', 'my-connector', { setupComponent() { this.set('classNames', ['foo']); } }); With the new changes I am seeing a wrapping span @eviltrout which is a bit of a blocker for me: [image] Outlet is defined as: {{plugin-outlet name="user-activity-bottom" connectorTagName='li' args=(hash model=model)}} Is…

Plugin admin button broken styling

Development

kgish (Kgish) December 25, 2016, 12:53pm 5

Yes, it’d be very nice if we could get this fixed.

Topic		Replies	Views
Important changes to Plugin Outlets for Ember 2.10 Development	23	7134	June 1, 2018
Plugin-outlet incorrectly handles multiple plugins at the same outlet Bug	21	4605	May 18, 2018
Style broken on user-activity-bottom-outlet Bug	1	1188	June 22, 2016
Recent Discourse update broke plugin outlet in strange way Development	3	599	December 2, 2022
How to add action for button in plugin Development	2	1252	May 31, 2020

Plugin admin button broken styling

Related topics