Since the latest upgrade, my plugin button in the admin dashboard menu has lost the correct styling, as you can see here: [图片] My /connectors/admin-menu/app-admin-connector.hbs template looks like this: {{#link-to 'admin.pvda'}}{{i18n 'pvda.admin.menu_title'}}{{/link-to}}

I see that in the file app/assets/javascripts/admin/templates/admin.hbs the line: {{plugin-outlet "admin-menu" tagName="li"}} has been changed to: {{plugin-outlet name="admin-menu" connectorTagName="li"}}

For those interested, this is my workaround until someone from the Discourse team fixes it. Basically I need to unwrap the stuff inside the span like this: ... ` to this: ... {{#link-to 'admin.pvda' id='admin-menu-pvda'}} {{i18n 'pvda.admin.menu_title'}} {{/link-to}} api.onPageChange((url, title) => { // --- ADMIN PAGE --- // if (/\/admin\//.test(url)) { // Admin pages start with "/admin/*" let sel = '#admin-menu-pvda', pvda_menu_item = $(sel); if (pvda_menu_item.length) { let li = pvda_menu_item.parent(); if (li.is("li")) { let span = li.parent(); if (span.is("span")) { li.unwrap(); } } } } ... }

I think this is related to something @sam uncovered recently too [图片] Important changes to Plugin Outlets for Ember 2.10 Development Just to expand a bit, looks like if you want to set a class on wrapping component you would use: api.registerConnectorClass('user-profile-primary', 'my-connector', { setupComponent() { this.set('classNames', ['foo']); } }); With the new changes I am seeing a wrapping span @eviltrout which is a bit of a blocker for me: [image] Outlet is defined as: {{plugin-outlet name="user-activity-bottom" connectorTagName='li' args=(hash model=model)}} Is…

Plugin admin button broken styling

Development

kgish (Kgish) 2016 年12 月 25 日 12:53 5

Yes, it’d be very nice if we could get this fixed.

话题		回复	浏览量
Important changes to Plugin Outlets for Ember 2.10 Development	23	7141	2018 年6 月 1 日
Plugin-outlet incorrectly handles multiple plugins at the same outlet Bug	21	4612	2018 年5 月 18 日
Style broken on user-activity-bottom-outlet Bug	1	1188	2016 年6 月 22 日
Recent Discourse update broke plugin outlet in strange way Development	3	602	2022 年12 月 2 日
How to add action for button in plugin Development	2	1254	2020 年5 月 31 日

Plugin admin button broken styling

相关话题