I’m trying to improve the permalink redirects on the vbulletin importer. Vbulletin can have any of several URL formats. My solution is to create generic permalinks which will then be handled by permalink normalizations. Like this: Old URL: http://somesite/forums/f38/slug-blah-blah-blue-11769.html Permalink: oldlinks/topics/thread-11769 Normalization: /forums\/f[0-9]+\/.+-([0-9])+\.html.*/oldlinks\/topics\/thread-\1 [image] It looks like it should work to me, but it’s not. Have I missed a character somewhere?

I thought that perhaps my problem was that I didn’t need to \ escape the /s in my replacement string, but that doesn’t seem to have solved it either. And I’ve confirmed that the regex works, it’s the replacement that’s broken. If I create a permalink badword-11769 and use this /forums\/f[0-9]+\/.+-([0-9])+\.html/badword-\1 The redirect works fine. Edit: No, it doesn’t. Final edit: WRONG: /forums\/f[0-9]+\/.+-([0-9])+\.html/oldlinks\/topics\/thread-\1 RIGHT: /forums\/f[0-9]+\/.+-([0-9]+)\.html/oldlinks\/topics\/thread-\1 ^^ Sigh.

Thanks, @elijah. Are you saying I’m missing one, or that I’ve got an extra? In either case, it looks OK, right? I added an image of the normalizations since there’s no way to copy them.

I’m good with REs, but that means I know there are a maze of similar looking implementations all with slightly different syntax. Your RE looks to be / delimited, but has no closing /: /forums\/f[0-9]+\/.+-([0-9])+\.html.*/oldlinks\/topics\/thread-\1/ (And here I also wonder is it \1 or $1 for substitutions?)

[image] elijah: Your RE looks to be / delimited, but has no closing /: [image] elijah: (And here I also wonder is it \1 or $1 for substitutions?) Here’s the most convenient answer to those questions: [image] There’s no trailing / in their example (I think I included one in one of my earlier attempts), and yes, it’s \1 to insert captures.

[image] pfaffman: There’s no trailing / in their example Isn’t there? I.e. /(topic.*)\?.*/ I can’t help but wonder, do you actually have URLs that have “.html” towards the end, and if you do, how often are they followed by zero or more nothing, anything, everything characters?

I meant after the replacement string. I have a / at the end of my RE (right?), but not the end of the replacement. [image] Mittineague: I can’t help but wonder, do you actually have URLs that have “.html” towards the end, I don’t know. Perhaps not. In other systems I’ve seen various cruft after the URL (as the example replacement suggests). I’m probably safe removing that last .* to be sure. ####To recap: Normalization: /forums\/f[0-9]+\/.+-([0-9])+\.html/oldlinks\/topics\/thread-\1 works: http://localhost:3000/oldlinks/topics/thread-11769 no joy: http://localhost:3000/forums/f38/a-bunch-of-words-11769.html I’ve checked the regex at http://regexr.com/ & it seems to work there. I’ve done something similar in the past. I’m stumped.

Problem with permalinks, or regex?

Product Support

elijah (Eli the Bearded) March 9, 2017, 12:40am 2

Trailing slash on the RE?

Topic		Replies	Views
Permalink normalization regex problem Development	1	1021	December 17, 2016
How does permalink normalization with regex work? Product Support	3	176	March 11, 2025
Redirects in Discourse from Xenforo Product Support	3	377	April 27, 2024
Non-permalink normalizations Development	11	1519	May 11, 2017
Permalinks not working for some URLs Product Support	1	1025	December 4, 2016

Problem with permalinks, or regex?

Related topics