I’m trying to use the docker image for tests both on my mac, and also on travis. For a while now the qunit tests have been failing on exactly the same tests, and I can’t figure out why. The steps I’m taking are the same on my mac and on travis: ./bin/docker/boot_dev # Load the Discourse development docker image, and set up ./bin/docker/bundle install --retry=3 --jobs=3 # Install dependencies ./bin/docker/psql "-c 'ALTER USER discourse WITH SUPERUSER;'" RAILS_ENV=test ./bin/docker/rake db:drop db:create db:migrate # Migrate the database (the psql hack is due to this issue). Every time, I get these test failures: Module Failed: Acceptance: Composer Test Failed: Tests the Composer controls Assertion Failed: clicking the toggle hides the preview Expected: true, Actual: false :49 Module Failed: Acceptance: Modal Test Failed: modal Assertion Failed: there is no modal at first Expected: true, Actual: false :49 Module Failed: Acceptance: Search - Full Page Test Failed: update username through advanced search ui Assertion Failed: "autocomplete" popup is visible Expected: true, Actual: false Assertion Failed: "autocomplete" popup has an entry for "admin" Expected: true, Actual: false Assertion Failed: Error: Element .search-advanced-options .autocomplete ul li a:first not found. Expected: true, Actual: false Test Failed: update category through advanced search ui Assertion Failed: has "faq" populated Expected: true, Actual: false Assertion Failed: has updated search term to "none #faq" Expected: none #faq, Actual: none :49 Module Failed: Acceptance: Topic Test Failed: Reply as new message Assertion Failed: it fills up the composer with the right user to start the PM to Expected: someguy, Actual: Assertion Failed: it fills up the composer with the right user to start the PM to Expected: test, Actual: Assertion Failed: it fills up the composer with the right group to start the PM to Expected: Group, Actual: :49 Time: 134884ms, Total: 2029, Passed: 2019, Failed: 10 phantomjs /src/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit 200000 Does anyone have any ideas what could cause this? Is there some dependency that’s out of date in the discourse_dev image that doesn’t get updated with bundle? I’ve tried apt-get update; apt-get upgrade but that doesn’t seem to help. You can see one of the failing travis jobs here - qunit tests are around line 6730.

Works fine for me on Linux with the latest tests-passed branch checked out: ~/Projects/discourse sudo d/bundle exec rake "qunit:test['200000']" phantomjs /src/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit 200000 Unable to access network phantomjs://code/run-qunit.js:34 Puma starting in single mode... * Version 3.6.0 (ruby 2.3.3-p222), codename: Sleepy Sunday Serenity * Min threads: 0, max threads: 16 * Environment: development * Listening on tcp://0.0.0.0:60099 Use Ctrl-C to stop phantomjs /src/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit 200000 Running: {} ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Time: 159725ms, Total: 2098, Passed: 2098, Failed: 0 Tests Passed I’m not sure this helps a great deal…

Yeah, it also works fine for me running the tests natively on my mac. And natively on travis it also seems to be fine (judging by discourse’s own CI tests). It’s just the discourse_dev image that seems to be breaking things for me, and I can’t figure out what’s different about it… :confused:

Try installing the latest version of PhantomJS in the image. I believe we’re running an outdated version.

We should get that fixed I thought @Falco posted a new dev image recently? no

I’ll give that a try - thanks :slight_smile: I was under the impression that you guys used the docker image for the internal CI server that runs before pushing to tests_passed? Or is this thread out of date?

The boot_dev is using a somewhat old image, just a sec.

[תמונה] david: It’s just the discourse_dev image that seems to be breaking things for me, and I can’t figure out what’s different about it… :confused: Sorry, that’s what I meant. Running the discourse_dev image in docker (in Linux) the tests pass fine for me… I see how I wasn’t as clear as I could have been. ~/Projects/discourse sudo docker images REPOSITORY TAG IMAGE ID CREATED SIZE [...] discourse/discourse_dev latest bed996f08446 5 months ago 1.67GB [...] ~/Projects/discourse sudo docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES bba77cff4858 discourse/discourse_dev:latest "/sbin/boot" 3 hours ago Up 3 hours 0.0.0.0:1080->1080/tcp, 0.0.0.0:3000->3000/tcp discourse_dev I frequently do d/shutdown_dev, d/reset_db, d/boot_dev cycles, could that be affecting things?

[תמונה] LeoMcA: I frequently do d/shutdown_dev, d/reset_db, d/boot_dev cycles, could that be affecting things? Yes, though we should be a bit smarter about checking once a week for a new dev image, or something along those lines.

OK, boot_dev --init will use the latest image: https://github.com/discourse/discourse/commit/2e152f4d39e3b0f46769851d5840b30624d17b39 Be sure to nuke old image first… do docker ps to see if it is running.

Thanks @Falco. That new image certainly initialises quicker now that all the dependencies are up-to-date. When I ran boot_dev --init I got this warning Migrating database... rake aborted! Gem::LoadError: You have already activated rake 12.0.0, but your Gemfile requires rake 11.3.0. Prepending `bundle exec` to your command may solve this. /src/config/boot.rb:11:in ` ' /src/config/application.rb:1:in ` ' /src/rakefile:5:in ` ' LoadError: cannot load such file -- bundler/setup /src/config/boot.rb:11:in ` ' /src/config/application.rb:1:in ` ' /src/rakefile:5:in ` ' (See full trace by running task with --trace) rake aborted! Taking the advice of the error, I amended /bin/docker/rake to use bundle exec rake, and it worked better. If that’s the correct option, I made a PR here Unfortunately, the change doesn’t seem to have fixed the issue I’m having with QUnit, I’m still getting those same tests failing :frowning:

QUnit tests won't pass in discourse_dev docker image

Development

Falco (Falco) 25 ביולי,‏ 2017,‏ 3:41pm 20

Awesome, just tested this locally and it’s working. Merging the PR.

נושא		תגובות	צפיות
Qunit in Docker Development	6	1730	14 במאי,‏ 2020
Plugin QUnit tests are not running as part of rake qunit:test Development	7	2228	17 ביולי,‏ 2017
Issue regarding Docker development image Development	25	6843	27 ביולי,‏ 2017
RSpec tests won't pass on discourse_dev docker image Development	4	2022	26 באפריל,‏ 2017
Developing Discourse Plugins - Part 6 - Add acceptance tests Developer Guides testing , plugin-guides , tutorial	32	18355	2 ביוני,‏ 2022

QUnit tests won't pass in discourse_dev docker image

נושאים קשורים