Could someone help me make sense of this error that I’m seeing in my logs? Discourse.Dialect is undefined

Yeah it is ancient code we removed, upgrade all plugins, if it persists, remove one by one till it’s gone and report back with the culprit

Is it possible that a plugin is causing this error even when it is disabled (i.e. it’s still in the app. yml but not activated in site settings)? If so, everything seems to point to the abbreviations and acronyms plugin: [תמונה] Abbreviations and acronyms plugin Plugin Looks like a similar issue (involving Discourse.dialect_deprecated) to what I had with the discourse-solved plugin - @eviltrout fixed it with this commit So probably a similar solution required here. The author has not been seen since months and is not responding to various bug reports. Maybe the plugin should be tagged as broken?

[תמונה] sam: Plugin needs to be removed and app rebuilt So is this true for plugins in general: they can cause errors even when deactivated?

Yes, it is up to plugins to respect the “disabled” setting in their own programming - their javascript and ruby code is still loaded regardless. Some somewhat relavent discussion: [תמונה] Reporting which plugin has caused the error Feature based on the errors I get in the admin panel, I feel discourse can understand which plugin has caused the error. look at these errors e.g. Uncaught TypeError: Cannot read property 'inlineBetween' of undefined Url: https://padpors.com/assets/plugin-third-party-66034ae1bc6977c5ec45dcf7adb5f8f9799ab0ff261ffd958c9425a34a956605.js Line: 1 Col or this one: TypeError: Discourse.Dialect is undefined Url: https://padpors.com/assets/plugin-third-party-66034ae1bc6977c5ec45dcf7adb5f8f9799ab0ff261ffd958… [תמונה] Reporting which plugin has caused the error Feature This would be great. As a possibly related thing, it would be nice if one plugin throwing a JS exception didn’t break other plugins. I don’t know enough about how plugins are loaded to know whether that would be feasible though…

[תמונה] david: it is up to plugins to respect the “disabled” setting in their own programming Okay, I read that as: it depends how the plugin is programmed, so that it is possible to program it so that it has no effect whatsoever when it is disabled. I think that is a valuable design specification for anyone sponsoring or buying a plugin: make it so that it can be fully disabled. (Can spare some headaches for many people.)

[תמונה] tophee: so that it is possible to program it so that it has no effect whatsoever when it is disabled. I’m not 100% sure that is true. Because some items get loaded automagically and just referencing a library that no longer exists will cause it to break, and that is before your setting check can even be invoked. There are “ways” around that though, but to say it can be 100% disabled and not cause an issue, I think is bordering on impracticality.

[תמונה] tophee: it has no effect whatsoever when it is disabled Yeah, ideally that would be the case. Sadly it’s not entirely realistic, especially for things like broken imports. (e.g. when discourse/lib/ajax was moved last year) Edit: @cpradio beat me to it

Yeah if we wanted easy peasy 100% robust disable Core would have to be able to issue a “restart” to all the services it is running Core would have to split up every plugin to have its own js file and have one js include per plugin (which may be desirable anyway cause it helps debugging a lot) (1) is surprisingly difficult.

[תמונה] tophee: everything seems to point to the abbreviations and acronyms plugin: To be fair, removing the acronyms and abbreviation did not stop those errors from occurring. So this plugin was either not causing any of them or it was not the only one doing so. Next try will be the affiliate plugin.

I can confirm that the affiliate plugin causes this error when core is upgraded but not the plugin. I dealt with this exact error earlier today. Updating the affiliate plugin solved it.

שגיאת Discourse.Dialect בלתי מוגדרת

תמיכה

sam (Sam Saffron) 13 ביולי,‏ 2017,‏ 11:39am 4

Yes absolutely will mark it now

Plugin needs to be removed and app rebuilt

נושא		תגובות	צפיות
Reporting which plugin has caused the error Feature	5	1316	10 ביולי,‏ 2017
Some users get javascript errors when trying to load our Discourse Product Support	1	3421	16 בינואר,‏ 2023
Rebuilding caused a JavaScript error on load Product Support	8	1255	17 ביוני,‏ 2016
Some official discourse plugins break after last update Bug	3	1461	31 באוקטובר,‏ 2016
Error when upgrading to the latest version due to third party plugin Self-hosting	3	740	2 באוקטובר,‏ 2019

שגיאת Discourse.Dialect בלתי מוגדרת

נושאים קשורים