Mini (Inline) Onebox Support RFC

Some suggestions:

  • Always prefer opengraph/etc to title cause stuff like this is bad:

https://www.yelp.com/biz/hummus-kitchen-new-york

<title>Hummus Kitchen - Reservations - 340 Photos &amp; 598 Reviews - Middle Eastern - Theater District - New York, NY - Phone Number - Menu - Yelp</title>
  • If title is too long always truncate and add elipsis at some sane length. (site setting maybe)

  • To opt out easily use this syntax: <https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400/5> https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400/5 , very easily detectable in our engine.

  • We got to protect the Mini Onebox from hammering servers… should only request first N bytes of the page.

I like the external link icon, keep in mind some people may want to style it themselves for self owned domains and so on, so a class with the domain name would be nice. I would definitely avoid re-hosting and downloading custom favicons per site in the initial implementation, a default font-awesome icon for off-site is fine for the default. (also consider adding it optionally for any external links, at a minimum add a class on every A for internal vs external)

7 个赞