this is a :bug:, but I think only developers will care about it. There’s an infinite loop in one of these replacements. I found it while running the nabble importer. I banged at it a bit before just commenting it out to solve my immediate problem. It looks like @zogstrip understands this. It seems that sometimes 183 gets stuck. I was wondering why these 170K messages need an entire holiday weekend to import. lib/email_reply_trimmer.rb main private def self.hoist_code_blocks(text) blocks = {} pattern = /^```\w*$\n.*?^```$/m text.gsub!(pattern) do |block| token = SecureRandom.hex blocks[token] = block token end [text, blocks] end def self.preprocess!(text) # normalize line endings text.gsub!("\r\n", "\n") # remove PGP markers

Do you have an example that fails?

I just assumed that it’d be self evident, because those regexes are so simple. Yes. I did get the script to spit out the errant one,but by the time I was sure this was the problem it was gone. I’ll try to run it again Real Soon Now.

And now it seems that maybe an upgrade made that problem go away, but now Nabble seems not to import any messages that have been emailed in (as opposed to created in the Nabble web interface). If there’s some easy way to decode a MIME-encoded email, I’d love to know about it.

Not sure about the “MIME-encoded email”, but at least I can reproduce the problem in EmailReplyTrimmer. I’ll fix it tomorrow. This is now fixed. FIX: Regular expressions could take a long time to finish (#12) master ← gschlager:fix_regex merged 08:23AM - 14 Sep 17 UTC (UTC) [תמונה] gschlager +31 -11 The `[\s\S]` was causing problems (the matching could take forever) when none of… the backreferenced words (e.g. `Am|schrieben\sSie`) was found. I replaced it with `.` and the `/m` option and added a test. @ZogStriP Can we release a new version if this is fine?

This seems to improve things, though I still have messages that are taking >30 seconds to parse a message. They all look Really Long (> 500K bytes?). Do you want them?

My solution was to truncate the posts at 50k. It turns out they didn’t want that list anyway (a bunch of cvs reports). I wrote code that I think saves the bad messages to files, but really, who wants 500k posts?

Infinite loop in email_reply_trimmer

Development

gerhard (Gerhard Schlager) 18 בספטמבר,‏ 2017,‏ 10:01pm 8

Sure, send me a few of those. I’ll take a look.

נושא		תגובות	צפיות
Tweaking patterns in email_reply_trimmer Development fixed	4	979	6 באוגוסט,‏ 2026
Better email reply parsing :e-mail: Feature email , feedback	7	7293	4 בפברואר,‏ 2016
Incorrect handling of reply-by-E-mail in topics Product Support	2	1070	18 בדצמבר,‏ 2018
Where to discuss issues with email_reply_trimmer? Product Support email	6	956	21 בנובמבר,‏ 2019
Incoming emails are elided but not trimmed Product Support	4	761	13 בפברואר,‏ 2022

Infinite loop in email_reply_trimmer

נושאים קשורים