OneBox is not processing Phabricator URLs. Can you help figuring out whether the fix belongs more to OneBox or Phabricator, please? FWIW the Phabricator project itself is using Discourse. Examples: A project repository Phabricator · phabricator A task [图片] T180854 Create discourse-mediawiki.wmflabs.org (pilot instance) discourse-mediawiki.wmflabs.org is planned to be a pilot for discourse.mediawiki.org, a developer support channel. A commit ⚙ D18770 Add support for nullable parameter types Meanwhile, GitHub equivalents are very informative and look gorgeous: https://github.com/discourse/discourse https://github.com/thingles/foreground/issues/177 https://github.com/discourse/discourse/commit/faa597ff90730c68060137223b881d62a56ad4f9

Thank you @itsbhanusharma! Task created: https://secure.phabricator.com/T13018 PS: Hm, why this link rendered at least the page title when the links in the first post didn’t?

[图片] icaria36: why this link rendered at least the page title when the links in the first post didn’t? As per the Onebox Plugin, it uses the same tags used by social networks such as facebook to make them look beautiful. almost every major publication uses it into their websites. The protocol handbook is below and You can consider it for more information. [图片] Open Graph protocol The Open Graph protocol enables any web page to become a rich object in a social graph.

What I meant is why the URLs in the first post don’t render anything (they also have proper attribute) whereas the URL in my comment above did render a title. I have found a pattern, and now I don’t know whether this is a bug or a feature working as designed. Here goes a test showing the difference: A task (URL in new line right below) [图片] T180854 Create discourse-mediawiki.wmflabs.org (pilot instance) discourse-mediawiki.wmflabs.org is planned to be a pilot for discourse.mediawiki.org, a developer support channel. A task (URL in new line with an empty line in between) [图片] T180854 Create discourse-mediawiki.wmflabs.org (pilot instance) discourse-mediawiki.wmflabs.org is planned to be a pilot for discourse.mediawiki.org, a developer support channel. (URL in one line preceded by anything, some text, a blank space) A task: ⚓ T180854 Create discourse-mediawiki.wmflabs.org (pilot instance) ⚓ T180854 Create discourse-mediawiki.wmflabs.org (pilot instance)

Your first two examples invoke the onebox engine which creates those fancy looking boxes when the linked webpage contains enough metadata (like Open Graph tags). This happens only when there isn’t any other text on the same line. Leading spaces also disable the onebox engine. In all other cases Discourse tries to create a Mini Onebox, which essentially is just the title of the webpage. By default this works only for internal links on the same Discourse instance. You probably want to support the following feature request: Should onebox fall back on mini-onebox if no metadata is available?

Just fix your open graph / oEmbed tags, check validity at Iframely URL Debugger - Open Graph, Twitter Cards, oEmbed

[图片] codinghorror: Just fix your (Just for clarity, I have no affiliation with the Phabricator project. I happen to use Phabricator in my organization and I link to Phabricator URLs often.)

OK, the bug is on their side, so please follow up with them, not us. Thanks!

For clarity, Quim’s examples (of GitHub resources, specifically) are all hard-coded by OneBox and not achievable by Phabricator (or other third-party software) using OpenGraph tags, right? For example, the “Opened by (author) on (date)”, “changed x files with…”, “Enhancement” tag, and the text formatting in his examples are because OneBox hard codes various GitHub layouts: lib/onebox/engine/github_issue_onebox.rb main # frozen_string_literal: true require_relative '../mixins/github_body' module Onebox module Engine class GithubIssueOnebox #Author Lidlanca 2014 include Engine include LayoutSupport include JSON include Onebox::Mixins::GithubBody matches_regexp(/^https?:\/\/(?:www\.)?(?:(?:\w)+\.)?github\.com\/(? .+)\/(? .+)\/issues\/([[:digit:]]+)/) always_https def url m = match "https://api.github.com/repos/#{m["org"]}/#{m["repo"]}/issues/#{m["item_id"]}" end This file has been truncated. show original templates/githubissue.mustache main {{title}} opened {{created_at}} {{#closed_at}} closed {{closed_at}} {{/closed_at}} This file has been truncated. show original …and it doesn’t appear that a similar rendering is possible through OpenGraph. We could conceivably achieve something similar by submitting a pull request to OneBox, but such a request wouldn’t necessarily need to use OpenGraph (it looks like the GitHub layouts use an Accept header to retrieve the resource in JSON, and ignore the OpenGraph metadata on the pages). Also, I couldn’t find it documented anywhere, but Discourse appears to require an og:description property in order to OneBox a URL (ultimately in whitelisted_generic_onebox.rb::has_text?). This isn’t required by the OpenGraph spec linked above (og:description is “Optional Metadata”), which led to some confusion.

How can you summarize a page without any description? I don’t think an image, or title + image, is a sufficient summary.

OneBox doesn't render boxes for Phabricator URLs

Product Support

itsbhanusharma (Bhanu Sharma) 2017 年11 月 20 日 13:09 2

Simply because phabricator does not have the opengraph tags. ask them to add relevant tags to their <head> section and it will soon start supporting it.

话题		回复	浏览量
Incorrect or failing oneboxes for links to other discourse instances Bug	16	2500	2017 年8 月 17 日
Onebox requests being incorrectly redirected due to user-agent Product Support	18	2046	2019 年6 月 19 日
Onebox does not work when summary opengraph tag is not present? Product Support	33	3151	2017 年6 月 19 日
ABC News not oneboxing due to missing description Product Support	15	1486	2024 年9 月 21 日
Link preview not working for specific site Product Support	10	2597	2019 年12 月 13 日

OneBox doesn't render boxes for Phabricator URLs

相关话题