Avatars with .svg extension dont loaded in 2.2.0.beta3 +64 version

tgxworld · October 19, 2018, 8:16am

I had a look here and confirmed this is a regression.

app/models/optimized_image.rb

5f86564da


      
          
          def self.create_for(upload, width, height, opts = {})
            return unless width > 0 && height > 0
            return if upload.try(:sha1).blank?
          
            # no extension so try to guess it
            if (!upload.extension)
              upload.fix_image_extension
            end
          
            if !upload.extension.match?(IM_DECODERS)
              if !opts[:raise_on_error]
                # nothing to do ... bad extension, not an image
                return
              else
                raise InvalidAccess
              end
            end
          
            # prefer to look up the thumbnail without grabbing any locks
            thumbnail = find_by(upload_id: upload.id, width: width, height: height)

There was a change made to use IM_DECODERS to verify if an image can be optimized but we actually don’t need to optimize SVGs at all. What used to happen in the previous versions is that SVG “optimized images” are basically a copy of the original image.

github.com/discourse/discourse

app/models/optimized_image.rb

5f86564da


      
          if extension =~ /\.svg$/i
            FileUtils.cp(original_path, temp_path)

I think we should just avoid creating optimized images for SVG altogether and retain support.

Topic		Replies	Views
SVG avatar and profile summary layout issue Bug	2	695	March 20, 2020
Add the .svg file extension to "image files" Feature	18	1791	October 10, 2025
SVG Upload works, but broken url to image Bug	2	1711	June 20, 2016
SVG broken only in Firefox when discourse copies it from external url Product Support	11	1454	April 2, 2019
SVG Upload not working Bug	1	1477	June 6, 2016

Avatars with .svg extension dont loaded in 2.2.0.beta3 +64 version

Related topics