שגיאת 404 כאשר מחזירים את שם התג לאחר ששינית אותו מבלי לטעון מחדש את הדף

martin · 29 בינואר,‏ 2025,‏ 2:36am

Thanks for the detailed report, I’ve got a fix for this now which should be merged soon:

github.com/discourse/discourse

UX: Fix tag revert rename 404 error

discourse:main ← discourse:fix/tag-rename-404

opened 02:35AM - 29 Jan 25 UTC

martin-brennan

+70 -2

Changing a tag name and reverting it to a previous tag name choice on the same …screen (meaning, without reloading the page) causes a 404 error. Reproduction steps: * Open an existing tag page https://your-discourse.com/tag/a * Click the wrench, change the name and save * Open edit again, revert the name to the original tag name * 404 error This was happening because of the way we find existing objects in our store. Tags are using the name as the id/primary key unlike other records in the UI. When we get the existing object from the store we throw away the "new" ID, so we ended up with the old tag ID on the existing object, which led to a 404. To fix it we can just manually set the tag ID to what it is supposed to be from params in the tag show route. c.f. https://meta.discourse.org/t/404-error-when-you-revert-a-tag-name-after-changing-it-without-reloading-the-page/342559

נושא		תגובות	צפיות
Can't rename tag: The requested URL or resource could not be found Bug	9	736	12 בנובמבר,‏ 2020
Rename tag not working as expected Bug	4	762	30 באפריל,‏ 2021
Tag shows up in Tag list, but 404s when clicked Support tags	5	356	31 ביולי,‏ 2022
Unable to create tag when name is in existing tag with underscore Bug	10	1246	29 באוקטובר,‏ 2016
Can't Edit Tag Names Bug tags	3	288	9 בדצמבר,‏ 2023

שגיאת 404 כאשר מחזירים את שם התג לאחר ששינית אותו מבלי לטעון מחדש את הדף

נושאים קשורים