A discard confirmation modal appears when clicking ‘New Post’ if a post is pending approval

zogstrip · March 25, 2026, 2:10pm

I have a fix in the works - @martin what do you think?

github.com/discourse/discourse

FIX: Discard draft modal shown after submitting post for approval (#38870)

main ← fix/discard-draft-modal-after-enqueued-post

merged 08:39AM - 26 Mar 26 UTC

ZogStriP

+39 -1

When creating a new topic in a category that requires approval, the composer wou…ld show a "discard draft" modal on every subsequent attempt to open it (new topic or reply). The issue was in the post-enqueue handler in the composer service. After a post is enqueued, the code tries to push the pending post into `this.topicController.model.pending_posts`. When creating a new topic, the user is on the topic list — not viewing a topic — so `this.topicController.model` is undefined. Accessing `.pending_posts` on undefined throws a TypeError, which prevents `destroyDraft()` and `close()` from ever executing. The composer model stays on the service with dirty content, so any subsequent composer open triggers the discard draft modal. The fix adds optional chaining (`?.`) so the pending_posts push is safely skipped when no topic model is loaded. https://meta.discourse.org/t/397711

Topic		Replies	Views
Ask a user to revise their post before approving it? Feature approval , completed	12	1436	February 28, 2024
Allow the ability to Edit post on rejection UX review-queue	21	332	May 6, 2026
Users can see pending/rejected topics Feature completed	7	1472	December 22, 2023
What Happens to Posts that are not Approved? Support	4	2419	May 23, 2020
How to make the queued posts visible to their authors? Development	19	3261	April 29, 2016

A discard confirmation modal appears when clicking ‘New Post’ if a post is pending approval

Related topics