# A few small issue found during RPM package build

**URL:** https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974
**Category:** Development
**Created:** [30 januari 2019 om 23:27 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974 "2019-01-30T23:27:04Z")
**Posts on this page:** 7
**Page:** 1

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [30 januari 2019 om 23:27 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/1 "2019-01-30T23:27:04Z")

</div>

Found while building 2.2.0.beta10~git21.f7b7bc8abe

# files with x bit without a shebang line.

```plaintext
bin/docker/README.md
lib/javascripts/moment_locale/*.js
script/import_scripts/json_generic.rb
vendor/assets/javascripts/sweetalert.js

```

probably just chmod -x all the files

# zero byte files

```plaintext
app/assets/javascripts/admin/templates/components/flag-counts.hbs
app/assets/javascripts/admin/templates/components/permalinks-list.hbs
app/assets/javascripts/discourse/templates/modal/merge-topic.hbs
app/assets/javascripts/discourse/templates/modal/split-topic.hbs
app/views/list/top.erb
app/views/static/password_reset.html.erb
app/views/static/signup.html.erb
public/javascripts/ace/mode-text.js
spec/fixtures/plugins/my_plugin/nested/plugin.rb

```

are all of them expected?

---

<div class="post-metadata">

### Author: ![Stephen](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/stephen/32/95011_2.png) [@Stephen](https://meta.discourse.org/u/Stephen)
#### Post date: [30 januari 2019 om 23:28 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/2 "2019-01-30T23:28:14Z")

</div>

What RPM package? Discourse isn’t distributed in RPM.

---

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [30 januari 2019 om 23:29 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/3 "2019-01-30T23:29:03Z")

</div>

I build one myself. and our package check found those issues. Thought I would clarify them with upstream.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [31 januari 2019 om 00:10 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/4 "2019-01-31T00:10:39Z")

</div>

Does any of this need fixing for the release @j.jaffeux?

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [31 januari 2019 om 00:12 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/5 "2019-01-31T00:12:52Z")

</div>

None of the listed files should have the x bit set.

As for the empty files, if there are indeed useful, then we should add a comment explaining why/where they’re used.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [31 januari 2019 om 10:01 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/6 "2019-01-31T10:01:31Z")

</div>

Yes I see no reasons to act on this before release. Im assigning this to me, to try to remove these files after release.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [7 maart 2019 om 07:58 UTC](https://meta.discourse.org/t/a-few-small-issue-found-during-rpm-package-build/107974/8 "2019-03-07T07:58:47Z")

</div>


