When a post is created through the API with an embed_url property, the TopidEmbed that’s created on Discourse isn’t being destroyed when the topic is deleted. I don’t know if this is by accident or by design. The problem I’m having with it is that it makes it hard to setup any integration tests bet…

How are you fetching topic embeds? Maybe adding a scope like where("topics.deleted_at IS NULL && posts.deleted_at IS NULL) will help?

[圖片] tgxworld: How are you fetching topic embeds? I’m not fetching them, the embed_url is sent as a property when a post is published on Discourse through the wp-discourse plugin. The post can’t be created if the embed_url already exists because TopicEmbed validates the uniqueness of embed_u…

I think we need to make TopicEmbed trashable as well. I’m not too farmiliar with what TopicEmbed is used for though so maybe someone else from @team can assist.

I have worked a bit on topic embedding , added on my list. :pencil:

[圖片] tgxworld: I think we need to make TopicEmbed trashable as well. This is now done via: https://github.com/discourse/discourse/commit/aeead600363b8e80d75bbff0bdca2234064d895e

A post's TopicEmbed isn't destroyed when the post is deleted

Development

techAPJ (Arpit Jalan) 2017年四月18日 08:53 5

I have worked a bit on topic embedding, added on my list.

話題		回覆	觀看
How can I delete or undelete topics? Support	30	15545	2018年九月14日
Will WordPress know about the deleted topic in Discourse? WordPress	2	465	2023年十一月4日
Error message "embed url already being used" even after unlinking post from discourse WordPress	4	1044	2020年五月29日
Handle deleted topics better in embed Bug	2	991	2015年十一月20日
Hidden Discourse posts are still visible in WP as comments WordPress	4	614	2021年五月7日

A post's TopicEmbed isn't destroyed when the post is deleted

相關主題