# Ein falsch positiver Fall für „Title can't have more than 1 emoji"

**URL:** https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204
**Category:** Bug
**Created:** [5. März 2018 um 11:29 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204 "2018-03-05T11:29:35Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![dmitry\_fedyuk](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dmitry_fedyuk/32/293153_2.png) [@dmitry\_fedyuk](https://meta.discourse.org/u/dmitry_fedyuk)
#### Post date: [5. März 2018 um 11:29 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204/1 "2018-03-05T11:29:35Z")

</div>

![01](https://global.discourse-cdn.com/meta/original/3X/0/6/067127ea1707f475fd3002ff91535648dc37017b.png)

The title is «**What is the difference between Mage::getSingleton() and Mage::getModel() in Magento?**»

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [5. März 2018 um 12:48 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204/2 "2018-03-05T12:48:57Z")

</div>

I see, is it detecting those crazy quotes as emoji? That’s one for you @techapj perhaps?

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [5. März 2018 um 14:37 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204/3 "2018-03-05T14:37:01Z")

</div>

That should fix it @techAPJ [FIX: do not treat :: as a valid emoji by jjaffeux · Pull Request #5647 · discourse/discourse · GitHub](https://github.com/discourse/discourse/pull/5647) I let your review/merge it.

As a side note any :string: would be considered an emoji, I feel like we shouldn’t over-engineer it and just keep going with the simple regex we have. If it would become an issue, we could match this against our list of emojis, given it only happen in validation it wouldn’t be that bad.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [5. März 2018 um 14:49 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204/4 "2018-03-05T14:49:06Z")

</div>

> [@j.jaffeux](#):
>
> I let your review/merge it.

Looks good to me, merged. 👍

> [@j.jaffeux](#):
>
> If it would become an issue, we could match this against our list of emojis, given it only happen in validation it wouldn’t be that bad.

Sounds good, let’s see if it comes to that.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [6. März 2018 um 12:30 UTC](https://meta.discourse.org/t/a-title-cant-have-more-than-1-emoji-false-positive/82204/5 "2018-03-06T12:30:01Z")

</div>

This topic was automatically closed after 21 hours. New replies are no longer allowed.