# Ability to edit groups (or click Edit Group button) even if you are not logged in?

**URL:** https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773
**Category:** Bug
**Created:** [25 בדצמבר,‏ 2016,‏ 7:49pm UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773 "2016-12-25T19:49:31Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [25 בדצמבר,‏ 2016,‏ 7:49pm UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/1 "2016-12-25T19:49:31Z")

</div>

I was reading this topic [Improving the Groups page for 1.7](https://meta.discourse.org/t/improving-the-groups-page-for-1-7/53347) and visiting this forum [https://se23.life/](https://se23.life/) to see “auto-join” in action when I realized that I can see (and click) the “Edit Groups” button (change text, flair, delete/add users etc…) even if I’m not logged in.  
[Imgur: The magic of the Internet](https://i.imgur.com/ofzapHZ.png)

It seems very strange for a user not registered, note that I have not tried to edit anything, I would probably give me an error or permission denied.

Ping to @ChrisBeach for more tests.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [26 בדצמבר,‏ 2016,‏ 12:02am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/2 "2016-12-26T00:02:11Z")

</div>

Yea I noticed the bug. Will fix once I’m back from the holidays. 🙂

---

<div class="post-metadata">

### Author: ![boddhisattva](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/boddhisattva/32/121391_2.png) [@boddhisattva](https://meta.discourse.org/u/boddhisattva)
#### Post date: [26 בדצמבר,‏ 2016,‏ 12:53am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/3 "2016-12-26T00:53:28Z")

</div>

Hi @tgxworld , I’m new to the Discourse codebase but I would like to take a look at this issue & see if I could fix it while you are away. Is that ok ?

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [26 בדצמבר,‏ 2016,‏ 1:36am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/4 "2016-12-26T01:36:25Z")

</div>

Sure go for it 🙂

---

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [26 בדצמבר,‏ 2016,‏ 2:20am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/5 "2016-12-26T02:20:04Z")

</div>

Good spot @Trash. I just tried editing as a non-logged-in user and got a 404 error (and the edit didn’t persist).

Another minor point: when viewing the group list page as a non-logged-in user, groups are shown as “Closed” which is a little bit misleading. I think it would be nicer if the correct actions “Join” / “Request Membership” were shown, and clicking on them popped up the sign-up dialog (as per the behaviour with the like button).

 ![](https://global.discourse-cdn.com/meta/original/3X/2/5/25d2997a5cb1537604052070ee065a9d67f86310.png)

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [29 בדצמבר,‏ 2016,‏ 3:53am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/6 "2016-12-29T03:53:35Z")

</div>

Fixed in

[https://github.com/discourse/discourse/commit/3c4920d234163815aac844b28eec09ef3e2f05c1](https://github.com/discourse/discourse/commit/3c4920d234163815aac844b28eec09ef3e2f05c1)

@Trash Thanks for reporting

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [29 בדצמבר,‏ 2016,‏ 3:53am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/7 "2016-12-29T03:53:47Z")

</div>



---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [29 בדצמבר,‏ 2016,‏ 4:53am UTC](https://meta.discourse.org/t/ability-to-edit-groups-or-click-edit-group-button-even-if-you-are-not-logged-in/54773/8 "2016-12-29T04:53:37Z")

</div>

[https://github.com/discourse/discourse/commit/a481bf048facd5e0c9a896d52f210b450c5a3d08](https://github.com/discourse/discourse/commit/a481bf048facd5e0c9a896d52f210b450c5a3d08)

@ChrisBeach Fixed as well 🙂
