‘Add user to group….’ script has different field input for the two triggers

simon · October 11, 2023, 1:09am

Here’s a PR to fix the issue:

github.com/discourse/discourse-automation

FEATURE: allow User Custom Field input field to accept the UserField name

discourse:main ← scossar:feature-allow-either-user-field-name-or-user-custom-field-name-for-input

opened 01:07AM - 11 Oct 23 UTC

scossar

+46 -4

Currently the `add_user_to_group_through_custom_field` script expects the UserCu…stomField name to be used when the automation is triggered with the "Recurring" trigger, and the UserField name to be used when the automation is triggered by the "User first logged in" trigger. This is confusing for users. For both triggers, it would be better if the UserField name could be used. That's the name that is displayed on the Admin / Customize / User Fields page. This PR attempts to fix the issue in a backwards compatible way, so that existing automations that are making use of the UserCustomField name (for example: 'user_field_5') will not be broken. The PR also updates the "with one matching user" test to set the UserCustomField name in the way that Discourse sets the name - based on the UserField's id. Related discussion on Meta: https://meta.discourse.org/t/add-user-to-group-script-has-different-field-input-for-the-two-triggers/281813

Topic		Replies	Views
How does the 'Add user to group through User Custom Field' script work? Support automation	4	595	September 26, 2022
'Add user to group through custom user field’ not working? Support automation , user-custom-fields	6	483	October 10, 2023
Finding Userfield Custom Name for 'Add user to group through User Custom Field' Support automation , user-custom-fields	8	1043	November 3, 2023
Automatically add users to groups based on custom field value Feature automation , completed , user-custom-fields	7	2115	August 19, 2023
Discourse Automation 'Add user to group though User Custom Field' not working Bug automation	2	50	November 1, 2024

‘Add user to group….’ script has different field input for the two triggers

Related topics