# Adding new emojis **URL:** \ **Category:** Bug\ **Created:** [2017年十二月16日 00:00 UTC](https://meta.discourse.org/t/adding-new-emojis/76177 "2017-12-16T00:00:02Z")\ **Posts on this page:** 10\ **Page:** 1
**Author:** ![8BIT](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/8bit/32/76872_2.png) [@8BIT](https://meta.discourse.org/u/8BIT)\ **Post date:** [2017年十二月16日 00:00 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/1 "2017-12-16T00:00:02Z")
can’t seem to add new emojis… was working fine before update. ![33 PM](https://global.discourse-cdn.com/meta/original/3X/6/7/67d93489afadf696b10903ad46902838f1c4a173.png) ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年十二月16日 00:34 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/2 "2017-12-16T00:34:35Z")
Can we repro @jomaxro? ---
**Author:** ![jomaxro](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jomaxro/32/126216_2.png) [@jomaxro](https://meta.discourse.org/u/jomaxro)\ **Post date:** [2017年十二月16日 00:38 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/3 "2017-12-16T00:38:42Z")
Sure can! That should be a nacho emoji called test: ![image](https://global.discourse-cdn.com/meta/original/3X/c/6/c68b646b036f50a950fe8124ac53b4362e1a63a0.png) ![Nacho-0](https://global.discourse-cdn.com/meta/original/3X/9/3/933febd589714f24481a7d8b123119e05a2a0156.png) ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年十二月16日 00:39 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/4 "2017-12-16T00:39:25Z")
Ok this also needs some fixing @eviltrout ---
**Author:** ![8BIT](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/8bit/32/76872_2.png) [@8BIT](https://meta.discourse.org/u/8BIT)\ **Post date:** [2017年十二月16日 00:53 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/5 "2017-12-16T00:53:38Z")
so much sadness… but, happy to help identify an issue! emojis ho! ---
**Author:** ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)\ **Post date:** [2017年十二月16日 08:33 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/7 "2017-12-16T08:33:31Z")
I can probably take this of robin’s plate ---
**Author:** ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)\ **Post date:** [2017年十二月16日 19:31 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/8 "2017-12-16T19:31:08Z")
@sam this commit broke it: [FEATURE: uploads are processed a faster · discourse/discourse@eb428ef · GitHub](https://github.com/discourse/discourse/commit/eb428ef54dcc1d0d74f5d4a0d3fd12f1122dab65#diff-2493f61f43374781bb8d3ed4ae50ded9L21) Basically we are trying to access the url of the file when it hasn’t been uploaded yet. I propose the following fix, could you please review it ? I don’t think a loading indicator is needed here, it’s a rare operation and very fast, it would make the UI/code more complex for very limited added value. [https://github.com/discourse/discourse/pull/5440](https://github.com/discourse/discourse/pull/5440) Note: I also took this opportunity to refactor a little bit the file to our current coding style, let me know if you want a separate commit for this. ---
**Author:** ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)\ **Post date:** [2017年十二月16日 21:09 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/9 "2017-12-16T21:09:58Z")
This isn’t right it should not use message bus here, will look on Monday ---
**Author:** ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)\ **Post date:** [2017年十二月17日 23:32 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/13 "2017-12-17T23:32:30Z")
Fixed per: [https://github.com/discourse/discourse/commit/5e90abfaea9e6261b4b256f0cdb4f71f3be739c3](https://github.com/discourse/discourse/commit/5e90abfaea9e6261b4b256f0cdb4f71f3be739c3) Sorry about it, my bad I broke it. ---
**Author:** ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)\ **Post date:** [2017年十二月19日 07:00 UTC](https://meta.discourse.org/t/adding-new-emojis/76177/15 "2017-12-19T07:00:07Z")
This topic was automatically closed after 31 hours. New replies are no longer allowed.