# Admin.groups.manage.membership.automatic이 대체되지 않음

**URL:** https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215
**Category:** UX
**Tags:** groups
**Created:** [8월 30, 2024, 5:21오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215 "2024-08-30T17:21:38Z")
**Posts on this page:** 15
**Page:** 1

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [8월 30, 2024, 5:21오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/1 "2024-08-30T17:21:38Z")

</div>

![The image shows a screenshot of a computer or mobile device displaying a webpage, likely a social media platform. (Captioned by AI)](https://global.discourse-cdn.com/meta/original/4X/2/8/1/281e5ce363166d5e68ef0f65c0dba275e8e7e0c4.jpeg)

이것은 모든 사람에게 표시되어야 하나요?

> <https://github.com/discourse/discourse/blob/main/config/locales/client.en.yml#L5203-L5204>

---

<div class="post-metadata">

### Author: ![HamMan2118](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/hamman2118/32/383565_2.png) [@HamMan2118](https://meta.discourse.org/u/HamMan2118)
#### Post date: [8월 30, 2024, 5:37오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/2 "2024-08-30T17:37:57Z")

</div>

관리자 그룹 페이지에서도 확인할 수 있습니다.

 ![image](https://global.discourse-cdn.com/meta/original/4X/9/9/6/9968d80e89bccf4c91c83ed68209579e2cad09e7.png)

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [8월 30, 2024, 5:42오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/3 "2024-08-30T17:42:12Z")

</div>

모든 자동 그룹 페이지에서 나타나는 것 같습니다. 스크린샷 예시로 "moderators"를 선택했지만, staff, admins, 그리고 신뢰도 수준 그룹도 영향을 받습니다.

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [9월 20, 2024, 12:23오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/4 "2024-09-20T12:23:42Z")

</div>

모바일에서 그룹에 메시지를 보낼 수 있는 경우, 깨진 텍스트가 메시지 버튼을 이동시킵니다.

 ![_20240920_141814](https://global.discourse-cdn.com/meta/original/4X/f/2/d/f2dff5c9ac3312a0db716cd6b11d11a76c126f3d.jpeg)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [12월 4, 2024, 9:24오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/5 "2024-12-04T21:24:00Z")

</div>

참고… 우선순위 태그를 추가했습니다. 향후 몇 주 안에 검토할 예정입니다.

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [12월 4, 2024, 11:49오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/6 "2024-12-04T23:49:29Z")

</div>

수정은 꽤 간단할 것 같습니다.

현재 툴팁은 모든 사용자에게 표시되지만, 관리 영역(Admin section)의 문자열을 사용하고 있습니다:

> <https://github.com/discourse/discourse/blob/f75c43713b03ba17c6e5bee84d9d0b50c842ee0a/app/assets/javascripts/discourse/app/templates/group.hbs#L44-L54>

 ![image](https://global.discourse-cdn.com/meta/original/4X/2/f/a/2fa3c7f96c8e01be9b4270bf4988dde85e62cbc6.png)  
이 정보는 그룹 멤버를 추가할 수 있는 사람들에게만 관련이 있다고 생각합니다. 여기에는 관리자, 그룹 소유자, 그리고 `moderators manage categories and groups` 설정에 따라 모더레이터도 포함될 수 있습니다. 자동 그룹에는 소유자가 있을 수 없으므로, 자동 그룹을 관리할 수 있는 권한이 있는 사용자는 관리 영역 문자열에 접근할 수 있어야 하며, 그 외의 사용자에게는 숨겨지는 것이 적절하다고 봅니다.

```diff
+ {{#if this.canManageGroup}}
          {{#if this.model.automatic}}
            <DTooltip class="admin-group-automatic-tooltip">
              <:trigger>
                {{d-icon "gear"}}
                {{i18n "admin.groups.manage.membership.automatic"}}
              </:trigger>
              <:content>
                {{i18n "admin.groups.manage.membership.automatic_tooltip"}}
              </:content>
            </DTooltip>
          {{/if}}
+ {{/if}}

```

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12월 6, 2024, 8:52오전 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/7 "2024-12-06T08:52:47Z")

</div>

@Moin, 마음껏 PR 올려주세요 😉

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [12월 6, 2024, 8:54오전 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/8 "2024-12-06T08:54:46Z")

</div>

테스트를 작성할 수 없어요 ☹

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12월 6, 2024, 1:30오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/9 "2024-12-06T13:30:08Z")

</div>

괜찮아, 내가 할게 😉

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [12월 6, 2024, 1:34오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/11 "2024-12-06T13:34:30Z")

</div>

> <https://github.com/discourse/discourse/pull/30154>
>
> The tooltip introduced in \[#28630\](https://github.com/discourse/discourse/pull/2…8630) was displayed to all users, but it relied on text only available to staff. This resulted in a broken tooltip being shown to non-staff users.
> 
> See the report for more details: \[Meta Topic\](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215).
> 
> Fix Details:
> \* I think automatic groups do not have group owners, so users who can manage the group are always staff.
> \* The tooltip is now hidden for users, who cannot manage the group.
> \* Staff users, who can manage the group, still see the tooltip as expected.
> 
> 
> Before:
> Non-staff users saw a broken tooltip:
> !\[broken tooltip for user\](https://github.com/user-attachments/assets/03e0e800-2a02-4758-a1e1-db1422a40163)
> 
> After:
> Tooltip is hidden for non-staff users:
> !\[hidden tooltip for user\](https://github.com/user-attachments/assets/9a2494b2-cc25-45ba-b175-ef4486b64ee9)
> Tooltip is still visible for admin:
> !\[tooltip still visible for staff\](https://github.com/user-attachments/assets/ffa43eeb-f679-4911-a8d3-502400e01b7a)

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12월 6, 2024, 2:08오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/12 "2024-12-06T14:08:49Z")

</div>

감사합니다. 이 PR이 병합되면 수정될 것입니다.

> <https://github.com/discourse/discourse/pull/30155>
>
> Follow up to #28630 which added the tooltip on automatic group.
> 
> It was missin…g a check to ensure the current user is an admin, since only admins can manage automatic groups.
> 
> Reported in https://meta.discourse.org/t/324215 by @moin-Jana
> 
> Closes #30154

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [12월 6, 2024, 2:22오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/13 "2024-12-06T14:22:53Z")

</div>

> 현재 사용자가 관리자인지 확인하는 검사가 빠져 있었습니다. 자동 그룹을 관리할 수 있는 권한은 관리자만 가지고 있기 때문입니다.

흥미롭네요. `moderators manage categories and groups`(모더레이터가 카테고리와 그룹 관리)이 활성화되어 있으면 모더레이터도 할 수 있다고 생각했습니다. 그들에게는 “manage”(관리) 탭이 표시되거든요.

 ![Screenshot_20241206_151909_Firefox](https://global.discourse-cdn.com/meta/original/4X/2/4/7/247f4900dba41e926e2001a979becc1a152e4025.jpeg)

그래서 다른 그룹에서는 멤버를 추가할 수 있는데, 왜 여기서는 추가할 수 없는지 설명하는 것이 도움이 될 거라고 생각했습니다.

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12월 6, 2024, 7:36오후 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/14 "2024-12-06T19:36:13Z")

</div>

자동 그룹은 다르게 처리되는 것 같아. 코드에서 관리자 권한을 요구하는 검사를 봤는데, 그게 그냥 잔재일 수도 있지만…

@hugh / @martin 둘 중 누가 자동 그룹을 관리할 수 있는지 아는 사람이야?

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12월 7, 2024, 7:00오전 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/15 "2024-12-07T07:00:24Z")

</div>

이 주제는 16시간 후 자동으로 닫혔습니다. 더 이상 답변을 남길 수 없습니다.

---

<div class="post-metadata">

### Author: ![martin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/martin/32/491371_2.png) [@martin](https://meta.discourse.org/u/martin)
#### Post date: [12월 9, 2024, 1:41오전 UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/16 "2024-12-09T01:41:36Z")

</div>

Moin이 언급한 사이트 설정이 이 기능을 허용하는 것 같습니다. 관련 가디언 체크는 다음과 같습니다:

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/lib/guardian/group_guardian.rb#L18-L24>

하지만 클라이언트에서는 모호한 메시지를 보내고 있습니다 😅

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/app/assets/javascripts/discourse/app/models/user.js#L1091-L1095>

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/app/assets/javascripts/discourse/app/controllers/group.js#L117-L124>

`canManageGroup` 체크로 변경하기 위한 후속 PR입니다. 또한 `canManageGroup`의 사용자 모델 버전을 더 합리적으로 업데이트했습니다(이 그룹 컨트롤러에서만 해당 메서드를 사용함):

> <https://github.com/discourse/discourse/pull/30174>
>
> Followup 35ecd0335c70e4f008ae86ec5804dc60dbf41101
> 
> Since we have the moderator…s\_manage\_categories\_and\_groups setting,
> more than admins can manage groups, so we need to allow others to
> see this Automatic tooltip as well.
> 
> Also fixes an inconsistency with canManageGroup between the User
> model and Group controller, the latter is correct, allowing management
> of automatic groups if can\_admin\_group permission is true
