# Admin.groups.manage.membership.automatic not replaced

**URL:** https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215
**Category:** UX
**Tags:** groups
**Created:** [August 30, 2024, 5:21pm UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215 "2024-08-30T17:21:38Z")
**Posts on this page:** 1
**Showing post:** 16

<div class="post-metadata">

### Author: ![martin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/martin/32/491371_2.png) [@martin](https://meta.discourse.org/u/martin)
#### Post date: [December 9, 2024, 1:41am UTC](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215/16 "2024-12-09T01:41:36Z")

</div>

I think the site setting Moin mentioned does allow this, here is the relevant guardian check:

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/lib/guardian/group_guardian.rb#L18-L24>

But in the client, we are sending mixed messages 😅

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/app/assets/javascripts/discourse/app/models/user.js#L1091-L1095>

> <https://github.com/discourse/discourse/blob/4ddf7e61f99d42e22ad5ae36832882c734623614/app/assets/javascripts/discourse/app/controllers/group.js#L117-L124>

Here is a followup PR to change to check `canManageGroup`, and also update the user model version of `canManageGroup` to be more sensible (the only place using that is from this group controller):

[https://github.com/discourse/discourse/pull/30174](https://github.com/discourse/discourse/pull/30174)

---

_[View the full topic](https://meta.discourse.org/t/admin-groups-manage-membership-automatic-not-replaced/324215)._
