AI Agent group settings don't seem to be handled by the upcoming change removing the everyone group

Continuing the discussion from The road to stable, then permanent, for granular_anonymous_and_logged_in_groups_permissions:

I think the AI Agent permission settings are not yet handled correctly by the upcoming change.

The only change between these two screenshots is enabling the upcoming change. While proofread is offered as expected as long as the change is disabled, it is missing after enabling it.

The proofread agent is set up for “everyone”, so with the upcoming change I would expect this to result in logged_in_users. But this doesn’t seem to be the case. I am a logged-in user and the option still disappears from the interface.

I haven’t tested it, but I guess the same will happen with other agent group settings.

1 Like

Yeah I would consider this an edge case, since allowed_group_ids is stored on the AiAgent model, which doesn’t go through the automatic everyonelogged_in_users switcheroo I set up.

Will make a PR to fix.

This should handle it:

https://github.com/discourse/discourse/pull/43362

2 Likes

Thanks for reporting, confirming and open a PR for this. I spent some time evaluating what was happening with my agents or models.

I had to add the user groups manually even in the summary agents, because if I didn’t, the functionality would break completely.