Should this really be an alert? Or can it be a console.log entry? app/assets/javascripts/discourse/lib/autocomplete.js.es6 510f9c5be if (this.length !== 1) { alert("only supporting one matcher at the moment"); } I’m noticing it appearing on the Poll UI Plugin because I embed the editor in a Modal, while it is still open in on the topic/create new topic. It initially took me by surprise because I wasn’t sure what “only supporting one matcher at the moment” meant, it would be nice if this were 1) more specific, such as, “AutoComplete: only supporting one matcher in an editor at the moment” and 2) a console.log statement, since it isn’t really breaking anything (from what I can tell).

Related to this: [图片] Error when opening user preferences while post editor is visible Bug I’m running into this error here on meta. I can’t reproduce it in my development environment, but I always get it here on meta. https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/autocomplete.js.es6#L60-L62 Steps to reproduce: Click “New Topic” and leave the editor open Go to my user preferences

Thanks. I can’t believe I didn’t catch that. Guess I just got caught up with looking in the dev category :slightly_smiling:

Alert seems really odd here we should change it to a log keeping in mind IE has no console object @tgxworld perhaps have a look at this

Cleaned up per: [图片] Error when opening user preferences while post editor is visible Bug On the upside this did catch a pretty ugly bug… nonetheless fixed per https://github.com/discourse/discourse/commit/6d22354ac338fa9a98e89c67054abd77fad1c8fb https://github.com/discourse/discourse-tagging/commit/abec4de26b3bf3d42d18b26b1c9f50d2f2c0b6a4

Alert used to Notify AutoComplete Support?

Development

gerhard (Gerhard Schlager) 2016 年2 月 20 日 18:36 2

Related to this:

话题		回复	浏览量
Error when opening user preferences while post editor is visible Bug	7	1913	2016 年2 月 23 日
Reducing the frequency of display for the warning "Draft is being edited in another window." Feature	34	3429	2023 年12 月 4 日
Your topic is similar to alert empty Bug	1	1076	2016 年4 月 26 日
[Admin-Hinweis] Eines deiner Themes oder Plug-ins enthält Code, der aktualisiert werden muss Product Support	22	582	2026 年10 月 20 日
Disable the # autocomplete popup in post editor? Feature hashtag-autocomplete	23	1606	2024 年3 月 11 日

Alert used to Notify AutoComplete Support?

相关话题