Align right not working


#1

Is this image aligning right?

edit: it works here, but doesn’t work on my site… i wonder why

FIXED: able to fix it with cropping the image size beforehand


(Jerre) #2

It’s working! :smile:


(Sam Saffron) #3

The markdown bug here is that we are allowing the align attribute through (vspace as well), and a bunch of others, this should be sanitized.

cc @eviltrout


(Kane York) #4

Aligned images are pretty essential for banner topics, though.

However, I'd prefer if the CSS was fixed so that we don't have
the image bumping the reply controls over.

(Sam Saffron) #5

There may be 2 levels of sanitization in play, but general users should not be allowed all these attributes.


(Robin Ward) #6

I’m now sanitizing these attributes.

https://github.com/discourse/discourse/commit/43b997c1ce5968634cdf0a10ef1a5921a9544511

For banner topics and stuff, we should be using CSS.


(Jeff Atwood) #7