Allow reply-to individual instead of topic/forum (mailing list feature)

I managed to fix the problem with the reply_key not being substituted using this commit, which modifies the set_reply_key method in the Email::Sender class. However, I still can’t figure out why Reply-To becomes null when I change it to anything but ‘reply_by_email_address’. It is set correctly at the end of the header_args method, but I can’t figure out where it is unset.

Any thoughts? I think @featheredtoast is the staff member I see with the most recent edits to Email::MessageBuilder

Edit: After some debugging, this appears to happen somewhere in lib/mail/sender.rb before line 86, though not sure exactly where…

Edit #2: After further debugging, I found the problem to be the following line in the Email::Sender::set_reply_key method:

      @message.header['Reply-To'] =
        header_value('Reply-To').gsub!("%{reply_key}", reply_key)

This method was causing a Reply-To without a reply_key to be wiped. I added a simple if statement to exclude the function if there was no “reply_key” in it. As of this moment, the plugin is back to fully working status.

לייק 1