Approval button on user's profile doesn't work

zogstrip · May 26, 2026, 1:37pm

This will hopefully catch a couple of the edge cases you’ve all raised in this topic

github.com/discourse/discourse

FIX: Approve users stuck with a non-pending `ReviewableUser` (#40303)

main ← fix-approve-button-non-pending-reviewable

merged 02:38PM - 27 May 26 UTC

ZogStriP

+110 -37

Previously, clicking Approve on a user's admin profile 500'd with `Reviewable::I…nvalidAction` when that user had a non-pending `ReviewableUser` (e.g., after `UserDestroyer.destroy` was rescued because the user had posts), and toggling on `must_approve_users` also skipped those users — leaving them permanently un-approvable from the admin UI. This change gates the `:approve_user` action on `guardian.can_approve?(target)` instead of `status == "pending"`, fixes the auto-approval initializer to only skip users with a *pending* reviewable, and centralizes `updatable_reviewable_scores` so re-approval correctly flips `disagreed` scores back to `agreed`. https://meta.discourse.org/t/403620

Topic		Replies	Views
Notification claims X users for approval, but none are found Bug	24	745	May 26, 2026
New user approval broken in 2.3 beta 7? Bug	4	726	May 11, 2019
Why this user keeps showing in review tab without accepted button? Support	6	679	August 2, 2019
"must approve users" notifications are incorrectly triggered by old users Bug	3	620	April 20, 2024
Approve suspect user Bug	8	986	March 12, 2020

Approval button on user's profile doesn't work

Related topics