I realize it’s confusing, but I think we are talking about the same thing. This is the code that gets called when you approve a user (app/models/user.rb):
self.approved = true
self.approved_by = approved_by
self.approved_at = Time.now
enqueue_welcome_message('welcome_approved') if save
At the bottom, you’ll see where the ‘welcome approved’ email is sent. If we look at the code for
enqueue_welcome_message, notice that the email is only sent if the ‘send welcome message’ setting is enabled.
return unless SiteSetting.send_welcome_message?
Jobs.enqueue(:send_system_message, user_id: id, message_type: message_type)
I was asking if you had this setting disabled because that would keep the message from sending
This code was just updated yesterday, so if you update your Discourse installation, these “you’ve been approved” emails will go out no matter how you set the site setting. They’ll also be sent as an email, rather than site message. Give it a shot.