# Auto-add permissions/unsaved permissions prompt
**URL:** https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919
**Category:** UX
**Created:** [10월 30, 2018, 9:07오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919 "2018-10-30T21:07:00Z")
**Posts on this page:** 13
**Page:** 1
### Author:  [@Mark\_Walkom](https://meta.discourse.org/u/Mark_Walkom)
#### Post date: [10월 30, 2018, 9:07오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/1 "2018-10-30T21:07:00Z")
When editing permissions, it can be easy to add a new set but forget to click the `Add Permission` to apply it before closing the edit box (don’t judge me! :p).
Would it be possible to have either a reminder - saying `Unapplied Permissions` or similar - or just apply the new permissions when clicking `Save Category`?
---
### Author:  [@Falco](https://meta.discourse.org/u/Falco)
#### Post date: [11월 1, 2018, 9:45오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/2 "2018-11-01T21:45:32Z")
I second this. I did forget the apply too many times!
---
### Author:  [@simon](https://meta.discourse.org/u/simon)
#### Post date: [11월 1, 2018, 10:00오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/3 "2018-11-01T22:00:45Z")
I have forgotten to to this as well, but making a mistake by adding the wrong group to category permissions could have serious consequences. I think having requiring confirmation here is a good idea.
Without a confirmation, there would need to be some way to dismiss a permission after the Edit Permissions button has been clicked.
If it needs to be changed, maybe the Add Permission button could be changed to a green checkmark box, similar to what is used in the Setting controls.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [11월 2, 2018, 6:15오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/4 "2018-11-02T18:15:45Z")
Maybe a good starter task @erlend_sh?
---
### Author:  [@mipe](https://meta.discourse.org/u/mipe)
#### Post date: [2월 12, 2019, 8:36오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/5 "2019-02-12T08:36:25Z")
Hello,
I wanted to contribute and looked at this issue, I think it would be good enough if the design could be changed: By renaming the “Add Permission” Button into just “Add” and moving it to the same line as the combo-boxes:
It would be intuitive to click, rather than changing the logic (which would involve checking if something has changed in the combo-boxes and then showing a Message).
Let me know what you think
---
### Author:  [@mipe](https://meta.discourse.org/u/mipe)
#### Post date: [2월 13, 2019, 2:40오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/6 "2019-02-13T02:40:12Z")
Hello, I made the change and created a PR:
[https://github.com/discourse/discourse/pull/6999](https://github.com/discourse/discourse/pull/6999)
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [2월 14, 2019, 4:37오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/7 "2019-02-14T04:37:49Z")
I worry that this will not fit in some non English locales. maybe if its in some magic flexbox it would work. @awesomerobot can you have a very quick look at this.
---
### Author:  [@mipe](https://meta.discourse.org/u/mipe)
#### Post date: [2월 14, 2019, 4:45오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/8 "2019-02-14T04:45:54Z")
Yes, I figured I change it to a “+” instead of “Add”, sorry I haven’t mentioned that in the previous post
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [2월 14, 2019, 5:43오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/9 "2019-02-14T05:43:10Z")
I can see:
```plaintext
margin-left: 0.25em;
position: absolute;
```
so there is still a real chance this thing will overlap, we should probably use a flexbox here or float the element right or something.
---
### Author:  [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [2월 14, 2019, 3:41오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/11 "2019-02-14T15:41:18Z")
[Commented inline on Github](https://github.com/discourse/discourse/pull/6999/files#r256887046), but that’s the gist — `position: absolute` is unneeded here. Everything else seems ok with long strings.
> [@mipe](#):
>
> Yes, I figured I change it to a “+” instead of “Add”, sorry I haven’t mentioned that in the previous post
Good call, removing text certainly makes localization easier.
---
### Author:  [@mipe](https://meta.discourse.org/u/mipe)
#### Post date: [2월 15, 2019, 3:04오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/12 "2019-02-15T03:04:44Z")
Thanks a lot for the review, I changed it accordingly and added a right margin to the `permission-selector`.
In order to make the add-button align with the combo-boxes, I did the following:
` .add-permission { position: relative; top: 0.1em; }`
otherwise the button would float a few pixels higher then the combo-boxes.
Open for suggestions if there’s a better way to do it 🙂
---
### Author:  [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [2월 15, 2019, 5:03오후 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/13 "2019-02-15T17:03:05Z")
Great, I just merged in the change [UX: make adding permissions more visible and intuitive to click. (#6999) · discourse/discourse@159dd69 · GitHub](https://github.com/discourse/discourse/commit/159dd69fcb5c687fe200ba27b5753df0e85834c2). The button alignment is fine for now, there’s a bigger fix we’ll work on that should better resolve the alignment issues.
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [2월 18, 2019, 3:32오전 UTC](https://meta.discourse.org/t/auto-add-permissions-unsaved-permissions-prompt/100919/14 "2019-02-18T03:32:43Z")