I am using SAML for login for our internal users and enabled: must approve users auto approve email domains (with our domain) When my users are trying to login, they still have to wait for approval by staff. I was not expecting this behaviour based on the wording of the settings. As we are in t…

I’ve just tried to replicate this on my test site (no SAML), and it worked as expected, which may make it an SSO thing? Enabled must approve users Added “jammydodger.monster” to auto approve email domains Signed up new test user with email “test_fourteen@jammydodger.monster” Test user received a…

I’m not sure if they are related—but, I was wondering if you had these two commits on your test site: [image] Staff-generated invites bypass the must_approve_users requirement feature Per: And We are now done. @Wall-E feel free to rebuild to get the latest fixes. …

My test site is currently on 17227e9e53 , so should include those commits. :+1: What version are you using @Jonathan_Poyer ?

I’ve now upgraded to latest (I had not). I will have to wait on Monday to get someone else to test as I don’t have the hand on adding a new user. Will keep you informed

@Jonathan_Poyer Can I confirm that this is not something that changed with a recent update? From my investigation, it looks like DiscourseConnect has never supported auto approve email domains which is a bug. The bug will be fixed by FIX: DiscourseConnect login did not auto approve based on email do…

I have deployed the latest version available today (7da074d5). I have the following configured: must_approve_users: true auto approve email domains: mydomain.com SAML configured I have asked a user but I still see them as pending “Needs approval” [Screenshot 2022-06-07 at 09.03.25]

I think @tgxworld ’s fix was for DiscourseConnect and not SAML, which may explain why your site is still experiencing the issue. Is a fix for SAML on the cards too @tgxworld ?

Auto approve email domains still requires staff approval

Support

agungor June 4, 2022, 6:06pm 8

I’m not sure if they are related—but, I was wondering if you had these two commits on your test site:

Topic		Replies	Views
Auto-approval of users doesn't seem to work Support	3	484	June 18, 2022
Auto approve email domains not working Support	5	570	October 25, 2021
Auto_approve_email_domains still showing login.wait_approval screen Support	3	397	November 16, 2021
Auto-approve user accounts by email domain Support	5	931	July 17, 2020
How to bypass "must approve users" for some email domains? Feature	1	715	March 27, 2017

Auto approve email domains still requires staff approval

Related topics