Backup / restore puts database password on screen and in log


(Michael - DiscourseHosting.com) #1

When making or restoring a backup, the database password is not only shown in the ‘log’ screen, but it appears in the log file as well. That doesn’t seem like a very good idea…

Running: PGPASSWORD=XXXXXXXX pg_dump --schema=public --file='/var/www/discourse/tmp/backups/dbXXXX/2014-03-10-173034/dump.sql' --no-owner --no-privileges --verbose --host=localhost --username=uXXXX dbXXXX

(Jeff Atwood) #2

Something for you to address @zogstrip?


(Régis Hanol) #3

Fixed :tiger2:

https://github.com/discourse/discourse/commit/8c89931747fd8abc9a6fd5b910db44fd831cd9a1


(Régis Hanol) #4

This topic was automatically closed after 60 minutes. New replies are no longer allowed.