# Badge given even if not active

**URL:** https://meta.discourse.org/t/badge-given-even-if-not-active/48756
**Category:** Bug
**Created:** [17. August 2016 um 20:13 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756 "2016-08-17T20:13:54Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![Silvanus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/silvanus/32/62831_2.png) [@Silvanus](https://meta.discourse.org/u/Silvanus)
#### Post date: [17. August 2016 um 20:13 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/1 "2016-08-17T20:13:55Z")

</div>

Hiya! In my forum, we noticed that the badge (here especially “First Onebox”) is given (i.e. a notification is sent) even if the badge isn’t active. This leads to a problem, when the badge isn’t active: the notification link leads into a “not found”, and the badge isn’t listed in the list of badges for that user (that still got the message).

To clarify: Badge notification is sent, even if it’s not active.

---

<div class="post-metadata">

### Author: ![Silvanus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/silvanus/32/62831_2.png) [@Silvanus](https://meta.discourse.org/u/Silvanus)
#### Post date: [17. August 2016 um 20:16 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/2 "2016-08-17T20:16:34Z")

</div>

Also, probably a locale problem, but when users earn their badges, they are sent a message with the English title of that badge, despite the forum otherwise using Finnish locale.

Notification is, for example: “Ansaitsit ‘Reader’” (You earned ‘Reader’). In other places this badge is named in Finnish “Lukutoukka”.

(Maybe this message should be moved to locale/translation area…)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [17. August 2016 um 20:44 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/3 "2016-08-17T20:44:24Z")

</div>

Did you disable all badges via the site setting?

---

<div class="post-metadata">

### Author: ![Silvanus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/silvanus/32/62831_2.png) [@Silvanus](https://meta.discourse.org/u/Silvanus)
#### Post date: [17. August 2016 um 20:59 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/4 "2016-08-17T20:59:22Z")

</div>

No, badges are enabled globally (`enable badges` is checked).

The First Onebox badge was separately turned off in the badges list.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [17. August 2016 um 21:16 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/5 "2016-08-17T21:16:40Z")

</div>

This might be a bug then @sam

---

<div class="post-metadata">

### Author: ![HAWK](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/hawk/32/86627_2.png) [@HAWK](https://meta.discourse.org/u/HAWK)
#### Post date: [19. August 2016 um 02:47 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/6 "2016-08-19T02:47:26Z")

</div>

Yup, we have the same issue.  
[I reported it here a while back.](https://meta.discourse.org/t/404-when-clicking-on-badge-link-which-shouldnt-exist/47321)

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [19. August 2016 um 19:18 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/7 "2016-08-19T19:18:10Z")

</div>

Here’s a fix for the granting behaviour.

[https://github.com/discourse/discourse/commit/4061725a95f5013d0701e2c5ed6dc79f78e14dae](https://github.com/discourse/discourse/commit/4061725a95f5013d0701e2c5ed6dc79f78e14dae)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [22. August 2016 um 20:05 UTC](https://meta.discourse.org/t/badge-given-even-if-not-active/48756/8 "2016-08-22T20:05:24Z")

</div>

This topic was automatically closed after 3 days. New replies are no longer allowed.
