Badge granted notification links to 404

badge

(Neil Lalonde) #1

After changing your username, links to badges from your notifications will show the 404 page.

46%20PM

Repro:

  1. Be granted the “Basic” badge
  2. Change your username
  3. Click the notification link

(Mittineague) #2

The confirm warns that changing the username will break quotes and mentions

Maybe add badge / notification breakage to the warning message? Or simplify the message to a more general “bunch of stuff”?


(Neil Lalonde) #3

I would think that it should handle it instead of throwing up a 404 error page. Maybe show the current user’s badge page instead? Or the default badge page without filtering to a user.


(Jeff Atwood) #4

Maybe this just seems super narrow of a situation.


(Ivan Rapekas) #5

Relogin required after username changing. Probably such message should be added to the warning.


(Neil Lalonde) #6

This came up from a migration after sso was enabled and usernames changed after logging in for the first time. So all badge notification links are 404 on that site.


(Neil Lalonde) #8

I fixed this so it won’t error. It will render the badge page without a filter on username.


(Neil Lalonde) #9

(Neil Lalonde) #10

(Neil Lalonde) #11

Fix reverted. userBadgesAll is used when looking at some badge pages. The variable names seem opposite of what they mean. All = filtered to one badge and one user. Granted = not filtered.

See Regular and Leader badge list broken