# Badge group edit bug

**URL:** https://meta.discourse.org/t/badge-group-edit-bug/78829
**Category:** Bug
**Created:** [January 24, 2018, 2:23am UTC](https://meta.discourse.org/t/badge-group-edit-bug/78829 "2018-01-24T02:23:58Z")
**Posts on this page:** 3
**Page:** 1

<div class="post-metadata">

### Author: ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)
#### Post date: [January 24, 2018, 2:23am UTC](https://meta.discourse.org/t/badge-group-edit-bug/78829/1 "2018-01-24T02:23:58Z")

</div>

Repro:

- Create a new badge in admin, i.e. `admin/badges/new`

- Click the edit button next to the `group select combobox

- Modal does not open and exception is thrown in web console:

Reason:

The `admin-edit-badge-groupings` modal controller is missing the `ModalFunctionality` mixin.

PR:

[https://github.com/discourse/discourse/pull/5523](https://github.com/discourse/discourse/pull/5523)

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [January 24, 2018, 6:36am UTC](https://meta.discourse.org/t/badge-group-edit-bug/78829/2 "2018-01-24T06:36:38Z")

</div>

PR merged. Thank You! 🏆

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [January 24, 2018, 6:36am UTC](https://meta.discourse.org/t/badge-group-edit-bug/78829/3 "2018-01-24T06:36:45Z")

</div>


