# Badge Notifications aren't translated when granted in batches

**URL:** <https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882>\
**Category:** Bug\
**Created:** [2016年九月29日 19:54 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882 "2016-09-29T19:54:19Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![mackk](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mackk/32/59500_2.png) [@mackk](https://meta.discourse.org/u/mackk)\
**Post date:** [2016年九月29日 19:54 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882/1 "2016-09-29T19:54:19Z")

</div>

Eu não sou do Brasil, mas eu falo um pouco português 😃

Seems like this might actually be a bug? This is what I’m seeing.

 ![](https://global.discourse-cdn.com/meta/original/3X/d/f/df521996785996824642a0c59eefd19bd4bea8f4.png)

 ![](https://global.discourse-cdn.com/meta/original/3X/d/a/dad1c27b89f180d5aaffc66d1b204638f9a7f05d.png)

 ![](https://global.discourse-cdn.com/meta/original/3X/f/4/f449043f08a054f08cdda02f978dad6a39adbe89.png)

So the translation is pulled on the badges page, but not in the notifications dropdown, for some reason… (but some translations are pulled in the notifications dropdown).

---

<div class="post-metadata">

**Author:** ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)\
**Post date:** [2016年九月29日 20:12 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882/2 "2016-09-29T20:12:03Z")

</div>

This is a legit bug it looks like!

The call here:

> <https://github.com/discourse/discourse/blob/4061725a95f5013d0701e2c5ed6dc79f78e14dae/app/services/badge_granter.rb#L308>

isn’t wrapped on i18n as this one:

> <https://github.com/discourse/discourse/blob/4061725a95f5013d0701e2c5ed6dc79f78e14dae/app/services/badge_granter.rb#L33>

So, some badges get translated while the ones that are granted trough the big granter job aren’t.

---

<div class="post-metadata">

**Author:** ![mackk](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mackk/32/59500_2.png) [@mackk](https://meta.discourse.org/u/mackk)\
**Post date:** [2016年九月29日 21:16 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882/3 "2016-09-29T21:16:49Z")

</div>

Should we post this as a bug? I don’t fully understand the issue, so if you don’t mind posting it, that would be great! Thanks so much for looking in to this! I thought I was losing my mind…

---

<div class="post-metadata">

**Author:** ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)\
**Post date:** [2016年九月29日 22:00 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882/4 "2016-09-29T22:00:03Z")

</div>

Ok, I have a fix:

[https://github.com/discourse/discourse/pull/4476](https://github.com/discourse/discourse/pull/4476)

Since this can be pretty perf sensitive, when we make this 💯 you gonna have your badge notifications all localized!

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [2016年十月21日 05:22 UTC](https://meta.discourse.org/t/badge-notifications-arent-translated-when-granted-in-batches/50882/5 "2016-10-21T05:22:21Z")

</div>