# Basic site logos should hit the CDN

**URL:** https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306
**Category:** Bug
**Created:** [January 29, 2018, 9:22pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306 "2018-01-29T21:22:50Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)
#### Post date: [January 29, 2018, 9:22pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/1 "2018-01-29T21:22:50Z")

</div>

When we have a CDN defined, we should be leveraging that for various image assets (e.g. `logo url`, `logo small url`) that are relative URLs

e.g.: `logo_url='/uploads/default/original/1X/5b5cc13aa92459bb084ca1485bca80c480bfa6f0.gif'`

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [January 31, 2018, 4:39pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/2 "2018-01-31T16:39:47Z")

</div>

Where do you see that exactly?

---

<div class="post-metadata">

### Author: ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)
#### Post date: [January 31, 2018, 6:54pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/3 "2018-01-31T18:54:26Z")

</div>

sjcthree for example - the site logos were uploaded during the wizard - I haven’t changed them.

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [October 31, 2018, 3:04pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/6 "2018-10-31T15:04:40Z")

</div>

@nbianca can you make sure the images in the site settings use the CDN whenever they’re pointing at local images?

---

<div class="post-metadata">

### Author: ![nbianca](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nbianca/32/157984_2.png) [@nbianca](https://meta.discourse.org/u/nbianca)
#### Post date: [November 2, 2018, 12:10pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/8 "2018-11-02T12:10:54Z")

</div>

I tried reproducing this with latest-version and v1.9.0 (had to cherry-pick [a6c589d8](https://github.com/discourse/discourse/commit/a6c589d882852368d7add70b13040a604a9a5b72)). My CDN was provided by a local Minio instance.

The code also looks fine as it uses the same logic for other uploads.

@supermathie, have you seen it reproducing recently?

---

<div class="post-metadata">

### Author: ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)
#### Post date: [November 2, 2018, 3:00pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/9 "2018-11-02T15:00:13Z")

</div>

I haven’t set up any new sites recently, but I’ll re-run the wizard on a site and try it.

---

<div class="post-metadata">

### Author: ![gingerman](https://avatars.discourse-cdn.com/v4/letter/g/47e85d/32.png) [@gingerman](https://meta.discourse.org/u/gingerman)
#### Post date: [November 27, 2018, 3:35pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/10 "2018-11-27T15:35:31Z")

</div>

I just tried this with latest discourse version on a new site.

image uploads for logos only use the s3 urls instead of given s3\_cdn url. (but S3 cdn url is correctly picked up in image uploads within a post)

Also, discourse used to have a text box under the logo images where we can fill a custom image link. That was quite useful. Even in this case, we could have manually updated the CDN url if there is a text box.

---

<div class="post-metadata">

### Author: ![HAWK](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/hawk/32/86627_2.png) [@HAWK](https://meta.discourse.org/u/HAWK)
#### Post date: [November 27, 2018, 6:34pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/11 "2018-11-27T18:34:31Z")

</div>

> [@gingerman](#):
>
> Also, discourse used to have a text box under the logo images where we can fill a custom image link. That was quite useful. Even in this case, we could have manually updated the CDN url if there is a text box.

See [Downsides of the new logo UI in site settings](https://meta.discourse.org/t/confused-by-the-new-logo-ui-in-site-settings/102247)

---

<div class="post-metadata">

### Author: ![gingerman](https://avatars.discourse-cdn.com/v4/letter/g/47e85d/32.png) [@gingerman](https://meta.discourse.org/u/gingerman)
#### Post date: [November 28, 2018, 9:52am UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/12 "2018-11-28T09:52:04Z")

</div>

@hawk thanks for the note. I am part of the conversations there.

I am actually looking for a fix / way to get the s3\_cdn url in logos. Having a text box, is just a temporary fix.

---

<div class="post-metadata">

### Author: ![nbianca](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nbianca/32/157984_2.png) [@nbianca](https://meta.discourse.org/u/nbianca)
#### Post date: [November 28, 2018, 8:38pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/13 "2018-11-28T20:38:22Z")

</div>

Thank you for your report, @gingerman. I had another look and found the culprit.

I submitted a pull request to fix the issue and the changes will be merged soon.

[https://github.com/discourse/discourse/pull/6698](https://github.com/discourse/discourse/pull/6698)

---

<div class="post-metadata">

### Author: ![nbianca](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nbianca/32/157984_2.png) [@nbianca](https://meta.discourse.org/u/nbianca)
#### Post date: [January 7, 2019, 9:31pm UTC](https://meta.discourse.org/t/basic-site-logos-should-hit-the-cdn/79306/14 "2019-01-07T21:31:59Z")

</div>


