# Bookmark button class

**URL:** <https://meta.discourse.org/t/bookmark-button-class/100926>\
**Category:** Bug\
**Created:** [October 30, 2018, 10:31pm UTC](https://meta.discourse.org/t/bookmark-button-class/100926 "2018-10-30T22:31:55Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![MasterShake](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mastershake/32/123762_2.png) [@MasterShake](https://meta.discourse.org/u/MasterShake)\
**Post date:** [October 30, 2018, 10:31pm UTC](https://meta.discourse.org/t/bookmark-button-class/100926/1 "2018-10-30T22:31:55Z")

</div>

Let me preface this by saying I’m no dev so go easy 😅

I’ve noticed a class on the Bookmark button on the topic view “doesn’t get generated” (It just says {{bookmarkClass}} ) ?

 ![22%20PM](https://global.discourse-cdn.com/meta/original/3X/7/f/7fad63042139956b34aea4dae0dc1c77daac1ba3.png)

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [October 31, 2018, 10:06am UTC](https://meta.discourse.org/t/bookmark-button-class/100926/2 "2018-10-31T10:06:33Z")

</div>

Where exactly are you seeing that? Looks OK in your post, above, if I use the f12 browser inspector on the bookmark button, I see:

`<button class="widget-button btn-flat bookmark no-text btn-icon" aria-label="bookmark this post" title="bookmark this post"><i class="fa fa-bookmark d-icon d-icon-bookmark" aria-hidden="true"></i></button>`

---

<div class="post-metadata">

**Author:** ![MasterShake](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mastershake/32/123762_2.png) [@MasterShake](https://meta.discourse.org/u/MasterShake)\
**Post date:** [October 31, 2018, 10:21am UTC](https://meta.discourse.org/t/bookmark-button-class/100926/3 "2018-10-31T10:21:31Z")

</div>

Using inspector on this topic view. I havent checked other status’ of this to be fair so I cant account for other instances.

 ![18%20AM](https://global.discourse-cdn.com/meta/original/3X/2/0/2066afc091aa78cd8f9f9f769af203057b891d10.png)

Edit:  
**Chrome:** Version 69.0.3497.100 (Official Build) (64-bit)  
**OS:** MacOS Mojave 10.14

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [October 31, 2018, 10:26am UTC](https://meta.discourse.org/t/bookmark-button-class/100926/4 "2018-10-31T10:26:58Z")

</div>

Oh at the _topic_ level. Sure.

Confirmed:

`<button aria-label="Click to bookmark the first post on this topic" title="Click to bookmark the first post on this topic" id="ember1617" class="btn-default {{bookmarkClass}} btn btn-icon-text ember-view"> <i class="fa fa-bookmark d-icon d-icon-bookmark"></i><span class="d-button-label">Bookmark<!----></span></button>`

We should fix that.. @david would you like the honors? 🙇‍♂️

---

<div class="post-metadata">

**Author:** ![MasterShake](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mastershake/32/123762_2.png) [@MasterShake](https://meta.discourse.org/u/MasterShake)\
**Post date:** [October 31, 2018, 10:28am UTC](https://meta.discourse.org/t/bookmark-button-class/100926/5 "2018-10-31T10:28:55Z")

</div>

Confirmed for FF too 🙂

 ![27%20AM](https://global.discourse-cdn.com/meta/original/3X/8/4/84d783556b8a82d6d01caed55de13042e4156d41.png)

Edit: @codinghorror I believe they call that delegating 😃

---

<div class="post-metadata">

**Author:** ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)\
**Post date:** [October 31, 2018, 11:22am UTC](https://meta.discourse.org/t/bookmark-button-class/100926/7 "2018-10-31T11:22:52Z")

</div>

Fixed in

[https://github.com/discourse/discourse/commit/ff6676094f6e4cf7fbd3f962ee4d933c63c4f498](https://github.com/discourse/discourse/commit/ff6676094f6e4cf7fbd3f962ee4d933c63c4f498)

(cc @awesomerobot)

---

<div class="post-metadata">

**Author:** ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)\
**Post date:** [November 1, 2018, 6:00pm UTC](https://meta.discourse.org/t/bookmark-button-class/100926/10 "2018-11-01T18:00:03Z")

</div>

This topic was automatically closed after 30 hours. New replies are no longer allowed.