# Bookmark clock icon broken after changing icon set

**URL:** https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402
**Category:** Bug
**Tags:** fontawesome-pro
**Created:** [September 29, 2022, 3:37pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402 "2022-09-29T15:37:31Z")
**Posts on this page:** 15
**Page:** 1

<div class="post-metadata">

### Author: ![JonahAragon1](https://avatars.discourse-cdn.com/v4/letter/j/f19dbf/32.png) [@JonahAragon1](https://meta.discourse.org/u/JonahAragon1)
#### Post date: [September 29, 2022, 3:37pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/1 "2022-09-29T15:37:31Z")

</div>

When changing the FontAwesome Pro icons from Solid to Light, the icon that shows when you set a bookmark with a reminder time on a post no longer shows up.

It looks like the plugin changes `<use xlink:href="#discourse-bookmark-clock"></use>` to `<use xlink:href="#fal-discourse-bookmark-clock"></use>`, but this just appears blank because there is no `fal` version of this icon.

---

<div class="post-metadata">

### Author: ![jrgong](https://avatars.discourse-cdn.com/v4/letter/j/c57346/32.png) [@jrgong](https://meta.discourse.org/u/jrgong)
#### Post date: [September 30, 2022, 9:03am UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/2 "2022-09-30T09:03:50Z")

</div>

I have the exact same issue, on 2.9beta9 tests-passed

---

<div class="post-metadata">

### Author: ![jrgong](https://avatars.discourse-cdn.com/v4/letter/j/c57346/32.png) [@jrgong](https://meta.discourse.org/u/jrgong)
#### Post date: [April 24, 2024, 9:22am UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/3 "2024-04-24T09:22:46Z")

</div>

Digging out this one as it’s still an issue on 3.2

---

<div class="post-metadata">

### Author: ![jrgong](https://avatars.discourse-cdn.com/v4/letter/j/c57346/32.png) [@jrgong](https://meta.discourse.org/u/jrgong)
#### Post date: [August 23, 2024, 7:37am UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/4 "2024-08-23T07:37:21Z")

</div>

We still have this issue on 3.3 😃

---

<div class="post-metadata">

### Author: ![awesomerobot](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/awesomerobot/32/142900_2.png) [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [August 23, 2024, 2:52pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/6 "2024-08-23T14:52:33Z")

</div>

I’ve just made an update to the plugin that will use our default bookmark clock icon so it will no longer appear blank.

Unfortunately since this is a custom icon we built for Discourse based on the open source set of fontawesome icons, I don’t think we can actually build and distribute a version of this icon that uses the pro style as it would violate the fontawesome pro licensing.

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [August 29, 2024, 2:52pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/7 "2024-08-29T14:52:50Z")

</div>

This topic was automatically closed 6 days after the last reply. New replies are no longer allowed.

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [September 23, 2024, 1:39pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/8 "2024-09-23T13:39:40Z")

</div>



---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [September 23, 2024, 1:46pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/9 "2024-09-23T13:46:56Z")

</div>

> [@awesomerobot](#):
>
> I’ve just made an update to the plugin that will use our default bookmark clock icon so it will no longer appear blank.

I see the icon has been re-added in [eb39fb6](https://github.com/discourse/discourse-fontawesome-pro/commit/eb39fb6bdc567b77a54ce50366b804c9971467e2) but even when I checkout [your fix](https://github.com/discourse/discourse-fontawesome-pro/commit/cc8e59d79eca26147e8ec6d657362b1baad42b42) and not any newer commits on 3.3.1 stable, it brings back the bookmark clock icon but unfortunately it makes the more button (`d-icon-ellipsis-h`) and edit button (`d-icon-pencil-alt`) disappear… do you have any idea what is going on? I tried clearing the icon cache but to no avail.

 ![04580bafdc99c6f1cdf32ee06091e81c34aeddc6](https://global.discourse-cdn.com/meta/original/4X/c/e/1/ce1b65d47f20922f81273fd1b5837804f1e77e2c.png)

---

<div class="post-metadata">

### Author: ![Lilly](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/lilly/32/575047_2.png) [@Lilly](https://meta.discourse.org/u/Lilly)
#### Post date: [September 23, 2024, 1:54pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/10 "2024-09-23T13:54:15Z")

</div>

i wonder if related - [Some icons not showing up after upgrade](https://meta.discourse.org/t/some-icons-not-showing-up-after-upgrade/327730) 🤔

---

<div class="post-metadata">

### Author: ![awesomerobot](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/awesomerobot/32/142900_2.png) [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [September 23, 2024, 3:09pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/11 "2024-09-23T15:09:32Z")

</div>

> [@RGJ](#):
>
> not any newer commits on 3.3.1 stable

I think according to `.discourse-compatibility` you’re pinned to an older version of the plugin, right? maybe a compatibility issue with older versions of Discourse? [discourse-fontawesome-pro/.discourse-compatibility at eb39fb6bdc567b77a54ce50366b804c9971467e2 · discourse/discourse-fontawesome-pro · GitHub](https://github.com/discourse/discourse-fontawesome-pro//blob/eb39fb6bdc567b77a54ce50366b804c9971467e2/.discourse-compatibility)

I wouldn’t expect removing a reference to a single icon to break unrelated icons 🤔

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [September 23, 2024, 3:12pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/12 "2024-09-23T15:12:19Z")

</div>

> [@awesomerobot](#):
>
> I think according to `.discourse-compatibility` you’re pinned to an older version of the plugin, right?

Good catch, but no, I ignored that 🕶

---

<div class="post-metadata">

### Author: ![awesomerobot](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/awesomerobot/32/142900_2.png) [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [September 23, 2024, 3:20pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/13 "2024-09-23T15:20:47Z")

</div>

hmm and you don’t have the later commit that renamed the icons? [DEV: update plugin to be compatible with core upgrade to fontawesome … · discourse/discourse-fontawesome-pro@eb39fb6 · GitHub](https://github.com/discourse/discourse-fontawesome-pro/commit/eb39fb6bdc567b77a54ce50366b804c9971467e2)

When you dig into the inspector, is the reference for the icon `ellipsis` or `ellipsis-h`?

 ![image](https://global.discourse-cdn.com/meta/original/4X/a/e/a/aea8f9e5fc15e4ac415969ac678e8fa6d948232b.png)

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [September 23, 2024, 3:24pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/14 "2024-09-23T15:24:17Z")

</div>

So I am on `cc8e59d7`

![image](https://global.discourse-cdn.com/meta/original/4X/0/f/b/0fbd4b5195e5db701d13507fef66fb38dd263f1e.png)

---

<div class="post-metadata">

### Author: ![j.jaffeux](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/j.jaffeux/32/60297_2.png) [@j.jaffeux](https://meta.discourse.org/u/j.jaffeux)
#### Post date: [September 30, 2024, 8:45pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/15 "2024-09-30T20:45:44Z")

</div>

Im unclear if we need to keep this open @RGJ ?

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [September 30, 2024, 9:49pm UTC](https://meta.discourse.org/t/bookmark-clock-icon-broken-after-changing-icon-set/240402/16 "2024-09-30T21:49:55Z")

</div>

Well… it’s still an unresolved issue… I have no idea what is causing this.

So it would be good if anyone who had something useful to add would be able to add it 😉
