# Impostazioni collegamenti e icone dell'intestazione del marchio ora tipo di impostazione dell'oggetto

**URL:** https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732
**Category:** Feature
**Tags:** completed, brand-header
**Created:** [24 Aprile 2024, 5:22am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732 "2024-04-24T05:22:57Z")
**Posts on this page:** 6
**Page:** 1

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [24 Aprile 2024, 5:22am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/1 "2024-04-24T05:22:57Z")

</div>

Sto solo lasciando una nota qui che oggi ho unito una modifica che migra le impostazioni del tema `icons` e `links` a `type: objects` che [abbiamo recentemente rilasciato](https://meta.discourse.org/t/new-objects-type-for-theme-setting/305009?u=tgxworld).\n\n[https://github.com/discourse/discourse-brand-header/commit/7e304e0a12115c6596fc64ff173368cba1a28e7b\n\nNon](https://github.com/discourse/discourse-brand-header/commit/7e304e0a12115c6596fc64ff173368cba1a28e7b%5Cn%5CnNon) ci aspettiamo che le cose si rompano con questa migrazione, ma se dovesse succedere, per favore lascia una nota qui per farmelo sapere.

---

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [24 Aprile 2024, 12:25pm UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/2 "2024-04-24T12:25:23Z")

</div>

Purtroppo la modifica ha compromesso il componente e, di conseguenza, alcuni siti sono diventati inaccessibili.

Se hai già aggiornato, utilizza la modalità provvisoria per accedere al sito e disattivare temporaneamente il componente. Se non hai ancora aggiornato, ti preghiamo di non farlo finché non avremo risolto il problema.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [24 Aprile 2024, 12:55pm UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/3 "2024-04-24T12:55:51Z")

</div>

Questo [commit](https://github.com/discourse/discourse-brand-header/pull/38) risolverà il problema.

---

<div class="post-metadata">

### Author: ![lubezniy](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/lubezniy/32/137694_2.png) [@lubezniy](https://meta.discourse.org/u/lubezniy)
#### Post date: [26 Aprile 2024, 8:03am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/4 "2024-04-26T08:03:37Z")

</div>

Ciao. Sto ricostruendo Discourse. Durante il processo ho il seguente messaggio di errore:

```plaintext
[2024-04-26T07:56:32.414090 #1] INFO -- : cd /var/www/discourse & su discourse -c 'SKIP_EMBER_CLI_COMPILE=1 bundle exec rake themes:update assets:precompile'
[default] Impossibile aggiornare 'Brand Header Theme Component' (42): La proprietà in JSON Pointer '/0/text' deve essere presente. La proprietà in JSON Pointer '/1/text' deve essere presente. La proprietà in JSON Pointer '/2/text' deve essere presente.

```

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [26 Aprile 2024, 8:38am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/5 "2024-04-26T08:38:01Z")

</div>

Oops, mi dispiace. Sembra che ci sia un bug nella migrazione che verrà corretto in

> <https://github.com/discourse/discourse-brand-header/pull/39>
>
> This commit updates the migrations to assume that the old setting value
> may be …invalid so that we don't end up with a new setting which fails
> the objects schema validation.
> 
> This is a follow up to 7e304e0a12115c6596fc64ff173368cba1a28e7b which
> added migrations for the \`links\` and \`icons\` settings. We have
> gotten reports of errors happening with the migrations because the value of the old
> setting before migration did not follow the "informal" format required
> previously. Since there was nothing enforcing the format for the value
> previously, we need to assume the worst possible cases in our
> migrations.

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [19 Giugno 2024, 10:01am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/6 "2024-06-19T10:01:26Z")

</div>


