# Brand Header links and icons settings now Object setting type

**URL:** <https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732>\
**Category:** Feature\
**Tags:** completed, brand-header\
**Created:** [April 24, 2024, 5:22am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732 "2024-04-24T05:22:57Z")\
**Posts on this page:** 1\
**Showing post:** 5

<div class="post-metadata">

**Author:** ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)\
**Post date:** [April 26, 2024, 8:38am UTC](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732/5 "2024-04-26T08:38:01Z")

</div>

Oops sorry about that. Looks like there is a bug in the migration which will be fixed in

> <https://github.com/discourse/discourse-brand-header/pull/39>
>
> This commit updates the migrations to assume that the old setting value
> may be …invalid so that we don't end up with a new setting which fails
> the objects schema validation.
> 
> This is a follow up to 7e304e0a12115c6596fc64ff173368cba1a28e7b which
> added migrations for the \`links\` and \`icons\` settings. We have
> gotten reports of errors happening with the migrations because the value of the old
> setting before migration did not follow the "informal" format required
> previously. Since there was nothing enforcing the format for the value
> previously, we need to assume the worst possible cases in our
> migrations.

---

_[View the full topic](https://meta.discourse.org/t/brand-header-links-and-icons-settings-now-object-setting-type/312732)._