# Defect thema waarschuwing suggereert uitschakelen in plaats van bijwerken

**URL:** https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537
**Category:** UX
**Created:** [17 februari 2022 om 11:57 UTC](https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537 "2022-02-17T11:57:43Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [17 februari 2022 om 11:57 UTC](https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537/1 "2022-02-17T11:57:43Z")

</div>

A small one, but one that led to quite some confusion.

When a broken theme component is detected, a red bar appears stating “Your site may not work because theme / component %{theme} has errors. Disable it at %{path}.”

However, since (in this case) Discourse also detected that this theme component was not on its latest commit, the correct action here was “update” instead of “disable”.

In my experience that is the case for the majority of situations where this message appears. The quick fix would be to update the text to “Update or disable”, a more extensive fix would be to vary the message depending on whether there is an update available for the theme (update) component or not (disable).

---

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [17 februari 2022 om 12:12 UTC](https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537/2 "2022-02-17T12:12:44Z")

</div>

Encouraging people to click the automatic update on updates button is a good idea too.

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [17 februari 2022 om 13:04 UTC](https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537/3 "2022-02-17T13:04:17Z")

</div>

> [@RGJ](#):
>
> fix would be to update the text to “Update or disable”,

We’ve improved this message in the latest `tests-passed` to look something like:

 ![image](https://global.discourse-cdn.com/meta/original/3X/7/b/7bbc170835c43c219dac0a63750f431e20ec3658.png)

Makes sense to amend that to ‘reconfigure, update or disable’ 👍

[UX: Add 'update' to theme error message by davidtaylorhq · Pull Request #15977 · discourse/discourse · GitHub](https://github.com/discourse/discourse/pull/15977)

> [@pfaffman](#):
>
> Encouraging people to click the automatic update on updates button is a good idea too.

It is now the default, but we didn’t change existing themes (because historically people might have made local modifications to them, and we wouldn’t want to automatically overwrite those changes)

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [21 februari 2022 om 08:00 UTC](https://meta.discourse.org/t/broken-theme-alert-suggests-disabling-instead-of-updating/218537/4 "2022-02-21T08:00:20Z")

</div>

This topic was automatically closed after 3 days. New replies are no longer allowed.