Bundling more popular plugins with Discourse core

Sorry for taking this into a slight tangent, but I don’t think there’s a more suitable topic and it’s somewhat related with the earlier issue.

Since my previous message, I think there’s been further changes done on discourse/docker_manager that are breaking more things on builds of older versions. After a rebuild today, the whole admin section of Discourse stopped working with errors like this:

loader.js:247 Uncaught (in promise) Error: Could not find module `discourse/admin/models/admin-plugin` imported from `discourse/plugins/docker_manager/discourse/models/repo`

I was able to fix the build by using this on the yml:

  - git clone https://github.com/discourse/docker_manager.git && cd docker_manager && git reset --hard 314bbd78c200860c76bb62ced65b40e7cde5aa02 && cd ..

Unsure which one was the offending commit, but this was enough to get it working again.

I know, I know, I must upgrade (I mean that). But there’s likely other people like us who are stuck to older versions longer than planned for one reason or another, and having the older builds break without changing the version is a bit unexpected.

Anyhow, already found a workaround until we upgrade, so just sharing this in case it is useful to others in the same situation.

1 Like