Changes in profile preferences don't get saved automatically


(Claus Strasburger) #1

Something I recently noticed:
When I go to my profile preferences, e.g. /users/cfstras/preferences, and I edit my full name, the change doesn’t get saved immediately. Instead, I have to scroll down to the Save Changes button and click it.

However, as soon as I type in the text field, my changes appear at the top of the page, which might cause some confusion.

Suggestion:

  • Make a save button in the same style as in the admin section appear
  • Or add a second save button to the top of the settings page

Any thoughts?


(Sam Saffron) #2

Yeah … that should not be bound at that point, only after you click save should it update the name. Very confusing otherwise.

PR welcome.


(Kane York) #3

I’d like a second save button at the top, too, as well as fixing the autoupdate of the name, now that the preferences page is more than 1 screen tall.


(Sam Saffron) #4

Sure … PR welcome.

(make sure it works on mobile as well)


(Ryan Vergeront) #5

Here’s a pull request to unbind the display of the user’s name from the form.
https://github.com/discourse/discourse/pull/1954

Relatedly, thoughts on using normal textfields for the username and email fields instead of the pencil-icon popup style? I haven’t looked into how complicated that change would be, but I find normal text fields more user friendly.


(Ryan Vergeront) #6

Also, I can create a PR to add a button on top, but would like design feedback first. Maybe float it right like this?


(Sam Saffron) #7

Sure, a button on the top as well as on the bottom makes sense


(Jeff Atwood) #8

There is now a save button on top and bottom thanks to community PRs!


(Jeff Atwood) #9