Änderung der Zielgruppe von Enable-Formularvorlagen erstellt fälschlicherweise eine Option "Discourse aktualisieren" in der linken Seitenleiste

zogstrip · 24. März 2026 um 15:39

Danke für den Bericht @Noble_Fish

@martin, was hältst du von dieser Korrektur?

github.com/discourse/discourse

FIX: Admin sidebar links corrupted when toggling upcoming changes (#38828)

main ← fix/admin-sidebar-links-corrupted-on-setting-toggle

opened 03:39PM - 24 Mar 26 UTC

ZogStriP

+87 -46

The admin sidebar's `@cached` `sections` getter calls `amendLinksToSection` on `…AdminNavManager`, which permanently mutates its internal `#adminNavMap`. When the getter re-evaluates (e.g. after toggling the `enable_form_templates` upcoming change via MessageBus), links accumulate: they persist after a setting is turned off and duplicate on repeated toggles. This happens because `amendLinksToSection` pushes to the persistent `#adminNavMap` array, and there was no mechanism to reset it between evaluations. The fix adds a `resetNavMap()` method to `AdminNavManager` and calls it at the start of each `sections` evaluation, ensuring a clean slate. This also makes the existing dedup guards (plugin link filtering, `linkExists` check for upcoming_changes) redundant, so they are removed along with an unnecessary closure wrapper for login route links. https://meta.discourse.org/t/398151

Thema		Antworten	Aufrufe
New Admin Sidebar...where's the Update Discourse button? Bug admin-sidebar	14	381	19. Mai 2024
Navigation links added by plugins and theme components are missing Bug	4	542	20. Juni 2022
Custom menu links are modified and broken by Discourse Bug	8	498	23. März 2024
Settings layout Support admin-sidebar	4	83	29. Oktober 2024
Admin Panel Changes Support	3	113	16. September 2024

Änderung der Zielgruppe von Enable-Formularvorlagen erstellt fälschlicherweise eine Option "Discourse aktualisieren" in der linken Seitenleiste

Verwandte Themen