Changing the target audience of Enable form templates incorrectly creates an Update Discourse option in the left sidebar

zogstrip · March 24, 2026, 3:39pm

Thanks for the report @Noble_Fish

@martin what do you think of this fix?

github.com/discourse/discourse

FIX: Admin sidebar links corrupted when toggling upcoming changes (#38828)

main ← fix/admin-sidebar-links-corrupted-on-setting-toggle

approved 03:40AM - 25 Mar 26 UTC

ZogStriP

+87 -46

The admin sidebar's `@cached` `sections` getter calls `amendLinksToSection` on `…AdminNavManager`, which permanently mutates its internal `#adminNavMap`. When the getter re-evaluates (e.g. after toggling the `enable_form_templates` upcoming change via MessageBus), links accumulate: they persist after a setting is turned off and duplicate on repeated toggles. This happens because `amendLinksToSection` pushes to the persistent `#adminNavMap` array, and there was no mechanism to reset it between evaluations. The fix adds a `resetNavMap()` method to `AdminNavManager` and calls it at the start of each `sections` evaluation, ensuring a clean slate. This also makes the existing dedup guards (plugin link filtering, `linkExists` check for upcoming_changes) redundant, so they are removed along with an unnecessary closure wrapper for login route links. https://meta.discourse.org/t/398151

Topic		Replies	Views
New Admin Sidebar...where's the Update Discourse button? Bug admin-sidebar	14	381	May 19, 2024
Navigation links added by plugins and theme components are missing Bug	4	542	June 20, 2022
Custom menu links are modified and broken by Discourse Bug	8	498	March 23, 2024
Settings layout Support admin-sidebar	4	83	October 29, 2024
Admin Panel Changes Support	3	113	September 16, 2024

Changing the target audience of Enable form templates incorrectly creates an Update Discourse option in the left sidebar

Related topics