크리스마스 장식 컴포넌트 🎄

[Canapin (Coin-coin le Canapin)]

Hi @meghna, I’ve made a pull request with a few bugs fixed.

https://github.com/MeghnaAJ/discourse-christmas-decorations/pull/1#issue-1483066017

[meghna (Meghna Jalan)]

Thanks @Canapin, PR is merged.

[Jonathan5]

Thanks for this great theme component.

Have you noticed that the decoration image appears too soon when the sidebar is on? It looks like it appears at 1450px width. Around 1700px might be better with the sidebar. I don’t know whether that’s possible.

[Canapin (Coin-coin le Canapin)]

I now use this component instead of my own customizations, though I prefer rounded lightbulbs

However, there’s still a slight issue with the component. Lightbulbs’ bases are hidden behind the header:

I’ve made a PR to fix it.

https://github.com/MeghnaAJ/discourse-christmas-decorations/pull/2

---

For those who prefer rounded bulbs, you can add this CSS to your own theme:

.lightrope li {
        width: 12px;
        height: 15px;
    }
}

[meghna (Meghna Jalan)]

Thanks @Canapin, i’ve merged the PR.

[mstm]

Is it normal that with smartphones is so low?

[Canapin (Coin-coin le Canapin)]

Good catch! I’ll have a look.

---

edit: I made a PR.

[Canapin (Coin-coin le Canapin)]

The vertical position will be wrong if you use this theme along with Welcome Banner theme component even if the banner is hidden.

See:

https://meta.discourse.org/t/welcome-link-banner/218743/61?u=canapin

---

The most straightforward way to circumvent the issue is adding this CSS to your theme:

.above-main-container-outlet.welcome-link-banner-connectors {
    margin-bottom: 0;
}

[awesomerobot (Kris)]

I’ve updated the welcome link banner component to avoid this. Thanks again @Canapin!

[Roi]

Today there was an update for this component, so I updated it, even if it is disabled here as Christmas is over. Now I see the following:

Error: Invalid CSS after "...hadow: 0px math": expected expression (e.g. 1px, bold), was ".div($globe-height," on line 44 of ../../../tmp/discourse_theme_acdcea7663ae5fb94fa2525e54768195/discourse-christmas-decorations/stylesheets/lights.scss from line 2 of common.scss >> box-shadow: 0px math.div($globe-height, 6) $globe-width*2 $globe-sprea --------------------------^

Something is broken now.

[Falco]

Are you on latest Discourse?

[Roi]

I run 3.1.0.beta2 [e64d1c4105] here. So, Beta version yes, but for surely not the latest commit.

[Roi]

Same with [7eb6223b04]

[meghna (Meghna Jalan)]

I reverted the commit for now and will work with @Falco for proper fix.

[kynic]

I was testing this and found hats not showing on mobile view.

[fbpbdmin (deepblue)]

@meghna
thanks for this nice one !

one suggestion, should the bells on both side be colored, it is black/white now, not so holiday ? haha, your call tho…

[fbpbdmin (deepblue)]

in mobile view, it does not have the list contributors , if get a hat for each topic author, that looks too busy,
seems ok now on mobile, my 2c.

[meghna (Meghna Jalan)]

@fbpbdmin

one suggestion, should the bells on both side be colored, it is black/white now, not so holiday ?

I chose the black/white so that it looks good on all type of color schemes. PR welcome though

[fbpbdmin (deepblue)]

another suggestion,
it will nicer if could add a setting to change the light banner image, maybe several options, or change randomly.
say, turn on this component now, it is still several weeks till christmas, it is nicer if could have some changes …

[kynic]

Can you fix the hats for mobile?