Cleaning up e-mail logs

The old columns on email_logs table have been dropped.

https://github.com/discourse/discourse/commit/87537b679c74da58e9439c322f009f7bbd09966a

Another fix that would improve things in the future for sites with mailing list mode enabled.

https://github.com/discourse/discourse/commit/ba6f11c521b66870a6cd2c39785aa0dbcdabcecf

Can this be considered complete now @tgxworld?

Not quite I still have to work on cleaning up the PostReplyKey table which used to be a column on the EmailLog table. Pretty straight forward to clean up the records but I just need to read through the code path to make sure that we send the right email when a user tries to reply to a post with a deleted post_reply_key. I have this on my list this week.

This is done in

https://github.com/discourse/discourse/commit/36a7028f19b2b511862eb753b3ec72fccaffd2d7

Can you paste a screenshot here of what email you get when you reply to something and there is no Post Reply Key found, it may make sense to refine copy and UI there.

This is how the email looks like

Do we need that “security reasons” phrase there … I think without those words its actually a bit better.

Hmm got to check with @zogstrip regarding this. Based on what I know, there isn’t any security reason to restrict it but this is mainly done so that we keep disk space usage sane on large forums.

:fire: that sentence.

Done :slight_smile: Copy changes for old destination email template.. · discourse/discourse@f28a53d · GitHub