"Clear bookmarks" doesn't ask for confirmation


#1

The “Clear Bookmarks” won’t ask for any confirmation whatsoever. It will just immediately clear all bookmarks in a topic, no matter how many of them there are or where there are (eg, whether they are currently loaded on the page or not).

While I haven’t experienced this problem myself, this looks like a trap for punishing people with fat fingers.

Also, why is this button the same as the “Bookmark” (topic / first post) button? They are definitely not opposites!

You’re again confusing the concept of a bookmarked topic with that of a bookmarked post, aren’t you?


(Jeff Atwood) #2

I could see it asking for confirmation if it’s clearing more than one bookmark in a topic, sure.


(Régis Hanol) #3

Just added a confirmation when clearing more than 1 bookmark :rabbit:

https://github.com/discourse/discourse/commit/6be645e1ca6e88009bbfb65adb6bb4e273c983a5


(Régis Hanol) #4