# Clicking "Keep Editing" button doesn't do anything **URL:** https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301 **Category:** Bug **Created:** [April 3, 2023, 5:17am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301 "2023-04-03T05:17:21Z") **Posts on this page:** 8 **Page:** 1
### Author: ![jidanni](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jidanni/32/291938_2.png) [@jidanni](https://meta.discourse.org/u/jidanni) #### Post date: [April 3, 2023, 5:17am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/1 "2023-04-03T05:17:21Z")
The user has encountered this dialogue: ![Screenshot_20230403_130618_Chrome Dev](https://global.discourse-cdn.com/meta/original/4X/3/1/a/31a2f700196d034df656907e40f1b153fcb8df91.jpeg) The user chooses to continue editing. But all that happens is the Keep Editing button changes color. ![Screenshot_20230403_130158_Chrome Dev](https://global.discourse-cdn.com/meta/original/4X/5/b/a/5ba2f76a47fab76acb173dca8581c8effb15c3a2.jpeg) The user expects the dialogue to go away and he can resume editing. But that’s not what happens; the dialogue just stays there. Apparently the logic is he is supposed to make some different choice at this point. Naturally the user is totally confused. Now let’s discuss how we got into this awful mess. It is simply because the Save Edit button looks just the same as the Reply button. So when the user wants to save an edit he might actually hit the Reply button above it. Yes, they might not look exactly the same. However because often the user only sees an edge of them on a tiny screen, he mistakes the two blue squares to be the same. In fact it would be a good idea to disable all the reply buttons until he’s finished with his edit. ---
### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger) #### Post date: [April 3, 2023, 9:25am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/2 "2023-04-03T09:25:28Z")
> [@jidanni](#): > > the Save Edit button looks just the same as the Reply button. So when the user wants to save an edit he might actually hit the Reply button above it. I’m not 100% sure I can replicate this? Whenever I have the ‘Discard|Save for Later|Keep editing’ modal open I can’t use the reply buttons underneath. What am I missing? (even better if you can give me a step-by-step so I can walkthrough it) ---
### Author: ![jidanni](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jidanni/32/291938_2.png) [@jidanni](https://meta.discourse.org/u/jidanni) #### Post date: [April 4, 2023, 10:28am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/3 "2023-04-04T10:28:49Z")
You are right. The buttons look the same but they are disabled. Nothing happens when you touch them. Anyways I found something you could reproduce right here on this site instead of the openstreetmap site (which is where I made the above screenshots.) There should be a fourth button that resumes editing immediately. If we push the keep editing button this little box still is there at the bottom of the screen we have to touch it one more time to make it pop up. Yes it’s not that difficult but still… ![Screenshot_20230404_182752_Chrome Dev](https://global.discourse-cdn.com/meta/original/4X/9/f/6/9f6c33fd8da524b4b1d52ccd35e011d92831702a.jpeg) ---
### Author: ![Lhc\_fl](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/lhc_fl/32/268115_2.png) [@Lhc\_fl](https://meta.discourse.org/u/Lhc_fl) #### Post date: [April 4, 2023, 10:37am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/4 "2023-04-04T10:37:15Z")
> [@JammyDodger](#): > > I’m not 100% sure I can replicate this? I can replicate this. Choose a topic at will. Click reply to someone and enter some text in composer. Then switch to another topic and click reply. ---
### Author: ![Canapin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/canapin/32/119591_2.png) [@Canapin](https://meta.discourse.org/u/Canapin) #### Post date: [April 4, 2023, 11:05am UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/5 "2023-04-04T11:05:31Z")
I can replicate it as well, thanks for the info! Moving to #Contribute > Bug 🙂 ---
### Author: ![pmusaraj](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pmusaraj/32/119489_2.png) [@pmusaraj](https://meta.discourse.org/u/pmusaraj) #### Post date: [April 17, 2023, 9:54pm UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/11 "2023-04-17T21:54:30Z")
Thanks for the reports, everybody, this should fix the issue: [FIX: Dismiss modal when "Keep Editing" is used (#21117) · discourse/discourse@b869d35 · GitHub](https://github.com/discourse/discourse/commit/b869d35f94a4717c312f8dfcda52b37fb2a302b0) ---
### Author: ![Canapin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/canapin/32/119591_2.png) [@Canapin](https://meta.discourse.org/u/Canapin) #### Post date: [April 17, 2023, 10:01pm UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/12 "2023-04-17T22:01:11Z")
![Will Ferrell Comedy GIF by filmeditor](https://global.discourse-cdn.com/meta/original/3X/f/e/fe7b0aedb258e6e39274ff3b37cc962e5c464995.webp) ---
### Author: ![pmusaraj](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pmusaraj/32/119489_2.png) [@pmusaraj](https://meta.discourse.org/u/pmusaraj) #### Post date: [April 22, 2023, 12:00pm UTC](https://meta.discourse.org/t/clicking-keep-editing-button-doesnt-do-anything/260301/13 "2023-04-22T12:00:08Z")
This topic was automatically closed after 4 days. New replies are no longer allowed.