לחיצה על הלוגו מתצוגת דף ברירת מחדל נכשלת בטעינת הדף

david · 7 בינואר,‏ 2022,‏ 2:16pm

Should be fixed by this PR, once merged:

github.com/discourse/discourse

FIX: Refresh logic in discovery topic lists

discourse:main ← discourse:discovery-topics-refresh

opened 01:41PM - 07 Jan 22 UTC

davidtaylorhq

+13 -0

Before 6e0e6014, the flow looked something like: 1. `discovery/topics` contro…ller (which extends `discovery` controller) `afterRefresh()` calls `.send("loadingComplete")` 2. Bubbles to [`discovery` route](https://github.com/discourse/discourse/blob/554ff07786a81ed55c902c074d5ba787cfda0a3b/app/assets/javascripts/discourse/app/routes/discovery.js#L58) 3. Discovery route calls `controllerFor('discovery').loadingComplete()`. `loading` is set false, and the spinner disappears Now that `discovery/topics` defines `loadingComplete` as an action, the `discovery/topics` controller runs its own `loadingComplete` handler logic in step 1, and the action does not bubble any further. This commit adds action overrides in `discovery/topics`, so that the new actions only apply to the main `discovery` controller. The need for this does suggest some more radical refactoring is required, but these are very critical routes, and we are very close to a major release. Meta topic: https://meta.discourse.org/t/topic-list-loads-forever-in-some-circumstances/214042

נושא		תגובות	צפיות
Topic list loads forever in some circumstances Bug	4	853	7 בינואר,‏ 2022
Clicking home page logo no longer takes you to top of the page Bug	6	515	14 ביולי,‏ 2023
Refreshing everytime I open a topic Bug	9	381	29 בינואר,‏ 2024
Clicking Discourse Icon no longer reloads when category page is the default Bug	13	768	18 בינואר,‏ 2019
Forum loads slow after hitting Latest, New and Unread for the second time Support	4	586	7 בינואר,‏ 2022

לחיצה על הלוגו מתצוגת דף ברירת מחדל נכשלת בטעינת הדף

נושאים קשורים