Clicking on Logo gives error here on meta


(YOU) #1

Clicking on Logo gives error here on meta

Uncaught TypeError: Object [object Object] has no method 'refresh'

May be the error says it all? hope it renew the page if there is new/updated posts.


Regression - can't click logo to refresh Latest
(Moshe Katz) #2

Note that it appears to work just fine on some pages, but not on others (at least in my testing).

Works:

  • Topic pages
  • Category pages, including “New”, “Unread”, “Favorites”, etc.
  • User Profile pages

Doesn’t Work:

  • AFAICT, the only page that has this problem is the “Home” - i.e. “Latest” - page.

I traced the problem to this code, which is supposed to handle the exact case of refreshing the root page:

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/url.js#L170

However, the list_controller#reset function was removed in:

However, I could not find any comments or issue tracking that discuss what is going on here and why this function was removed.

@zogstrip - comments?


(Jeff Atwood) #3

YEAH ZOGSTRIP :blush:


(Régis Hanol) #4

That’s because I’m dumb :innocent:

I’ve fixed it and also added a test to make sure it does not regress again.

Thanks for investigating :wink:


(Régis Hanol) #5

This topic was automatically closed after 12 hours. New replies are no longer allowed.